Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recursion limit to FFI safety lint #130598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add recursion limit to FFI safety lint #130598

wants to merge 1 commit into from
+58 −19

Conversation

gurry
Copy link
Contributor

@gurry gurry commented Sep 20, 2024 •
edited
Loading

Fixes #130310

Now we check against tcx.recursion_limit() and raise an error if it the limit is reached instead of overflowing the stack.

@rustbot
Copy link
Collaborator

rustbot commented Sep 20, 2024

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 20, 2024
clubby789
clubby789 requested changes Sep 20, 2024
View reviewed changes
compiler/rustc_lint/messages.ftl Outdated Show resolved Hide resolved
@gurry
Add recursion limit to FFI safety lint
8ea1a53 
Fixes stack overflow in the case of recursive types
@gurry gurry force-pushed the 130310-improper-types-stack-overflow branch from 1a4286d to 8ea1a53 Compare September 20, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clubby789 clubby789 clubby789 requested changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stack overflow in ImproperCTypesVisitor::{check_type_for_ffi, check_variant_for_ffi}
4 participants
@gurry @rustbot @clubby789 @petrochenkov