Implement ACP 429: add Lazy{Cell,Lock}::get[_mut] and force_mut
#130476
+312
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the implementation of `force_mut`, I chose performance over safety. For `LazyLock` this isn't really a choice; the code has to be unsafe. But for `LazyCell`, we can have a full-safe implementation, but it will be a bit less performant, so I went with the unsafe approach.
rustbot
added
S-waiting-on-review
workingjubilee
force-pushed
the
more-lazy-methods-take-2
branch
2 times, most recently
from
1a9c521
to
6780eca
Compare
This comment has been minimized.
This comment has been minimized.
workingjubilee
force-pushed
the
more-lazy-methods-take-2
branch
from
6780eca
to
0702e28
Compare
|
Finally ran down the last missing import. |
Amanieu
reviewed
Sep 18, 2024
workingjubilee
force-pushed
the
more-lazy-methods-take-2
branch
from
0702e28
to
f22797d
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
5 tasks
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Sep 18, 2024
…ake-2, r=Amanieu
Implement ACP 429: add `Lazy{Cell,Lock}::get[_mut]` and `force_mut`
Tracking issue for `lazy_get`: rust-lang#129333
This was referenced Sep 18, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 18, 2024
…kingjubilee Rollup of 9 pull requests Successful merges: - rust-lang#97524 (Add `Thread::{into_raw, from_raw}`) - rust-lang#127988 (Do not ICE with incorrect empty suggestion) - rust-lang#129422 (Gate `repr(Rust)` correctly on non-ADT items) - rust-lang#129934 (Win: Open dir for sync access in remove_dir_all) - rust-lang#130450 (Reduce confusion about `make_indirect_byval` by renaming it) - rust-lang#130476 (Implement ACP 429: add `Lazy{Cell,Lock}::get[_mut]` and `force_mut`) - rust-lang#130487 (Update the minimum external LLVM to 18) - rust-lang#130513 (Clarify docs for std::fs::File::write) - rust-lang#130522 ([Clippy] Swap `manual_retain` to use diagnostic items instead of paths) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 19, 2024
Rollup merge of rust-lang#130476 - workingjubilee:more-lazy-methods-take-2, r=Amanieu Implement ACP 429: add `Lazy{Cell,Lock}::get[_mut]` and `force_mut` Tracking issue for `lazy_get`: rust-lang#129333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue for
lazy_get: #129333This lands the essential content of #129334 without adding DerefMut and without demanding that T-libs-api abrogate their procedure unnecessarily just to land a few functions. The case of the trait implementation can be considered in another PR.