Promote aarch64-apple-darwin to Tier 1 #128592
Merged
+4
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rustbot
added
S-waiting-on-review
|
This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp. The Miri subtree was changed cc @rust-lang/miri Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
@RalfJung This recreated PR incorporates the change you requested on my closed PR, re: the ci script comment change. Had I not stumbled on my git rebase, I could've commented on your review directly. Sorry about that. |
31 tasks
|
Not sure who should give the final approval here. Everything looks good from what I can tell and from what I can remember from previous promotions like #78228. Everything in #73908 looks like it is checked off or otherwise taken care of. rust-lang/rfcs#3671 has been approved. cc @shepmaster if you have any final thoughts. Also cc @rust-lang/release and @rust-lang/infra FYI. |
ehuss
added
the
relnotes
|
Oh wait, @evelynharthbrooke can you also update this line: IIRC, that value is not actually being used for anything at the moment, but it would be good to keep it updated. |
ehuss
added a commit
to ehuss/cargo
that referenced
this pull request
Aug 9, 2024
We will be promoting aarch64-apple-darwin to tier 1 soon via rust-lang/rust#128592. This updates our CI so that aarch64-apple-darwin runs the full test suite on nightly to keep this in-line with tier-1 support.
ehuss
added a commit
to ehuss/cargo
that referenced
this pull request
Aug 9, 2024
We will be promoting aarch64-apple-darwin to tier 1 soon via rust-lang/rust#128592. This updates our CI so that aarch64-apple-darwin runs the full test suite on nightly to keep this in-line with tier-1 support. This also removes the x86_64 stable macos job and replaces it with aarch64, mainly because aarch64 runs much faster, and presumably x86_64 support will go away some day.
|
These commits modify compiler targets. |
ehuss
added a commit
to ehuss/cargo
that referenced
this pull request
Aug 10, 2024
We will be promoting aarch64-apple-darwin to tier 1 soon via rust-lang/rust#128592. This updates our CI so that aarch64-apple-darwin runs the full test suite on nightly to keep this in-line with tier-1 support. This also removes the x86_64 stable macos job and replaces it with aarch64, mainly because aarch64 runs much faster, and presumably x86_64 support will go away some day.
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Aug 10, 2024
CI: Switch macos aarch64 to nightly We will be promoting aarch64-apple-darwin to tier 1 soon via rust-lang/rust#128592. This updates our CI so that aarch64-apple-darwin runs the full test suite on nightly to keep this in-line with tier-1 support. This also removes the x86_64 stable macos job and replaces it with aarch64, mainly because aarch64 runs much faster, and presumably x86_64 support will go away some day.
|
@ehuss I forgot to comment; i made the necessary change. :) |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 11, 2024
…imulacrum Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue rust-lang#73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
This was referenced Aug 11, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#120314 (core: optimise Debug impl for ascii::Char) - rust-lang#128536 (Preliminary cleanup of `WitnessPat` hoisting/printing) - rust-lang#128592 (Promote aarch64-apple-darwin to Tier 1) - rust-lang#128762 (Use more slice patterns inside the compiler) - rust-lang#128875 (rm `import.used`) - rust-lang#128882 (make LocalWaker::will_wake consistent with Waker::will_wake) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 11, 2024
Rollup merge of rust-lang#128592 - evelynharthbrooke:master, r=Mark-Simulacrum Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue rust-lang#73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
Mark-Simulacrum
added
relnotes
4 tasks
antoniospg
pushed a commit
to antoniospg/cargo
that referenced
this pull request
Sep 8, 2024
We will be promoting aarch64-apple-darwin to tier 1 soon via rust-lang/rust#128592. This updates our CI so that aarch64-apple-darwin runs the full test suite on nightly to keep this in-line with tier-1 support. This also removes the x86_64 stable macos job and replaces it with aarch64, mainly because aarch64 runs much faster, and presumably x86_64 support will go away some day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue #73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted.
This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.