Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use regexes in tidy checks #127428

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Don't use regexes in tidy checks #127428

merged 1 commit into from
Jul 7, 2024

Conversation

donno2048
Copy link
Contributor

No need for them, and it makes the tests and the checking simpler

r? @albertlarsan68

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jul 6, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jul 6, 2024

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@albertlarsan68
Copy link
Member

I'm not a fan of adding a dependency, is it possible to use what std provides instead of lazy_static?

GKFX
GKFX reviewed Jul 6, 2024
View reviewed changes
src/tools/tidy/src/style.rs Outdated Show resolved Hide resolved
@donno2048
Copy link
Contributor Author

@albertlarsan68 done

@albertlarsan68
Copy link
Member

Thanks for the PR!

r=me when CI green

@albertlarsan68
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 6, 2024

📌 Commit 4c4802b has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 6, 2024
@klensy
Copy link
Contributor

klensy commented Jul 6, 2024

7 commits, maybe squash?

@albertlarsan68
Copy link
Member

Good point, please squash @donno2048
@bors r-
r=me when squashed

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 6, 2024
@donno2048
Copy link
Contributor Author

@albertlarsan68

@albertlarsan68
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 7, 2024

📌 Commit 8d85043 has been approved by albertlarsan68

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2024
@bors
Copy link
Contributor

bors commented Jul 7, 2024

⌛ Testing commit 8d85043 with merge 98dcbae...

@bors
Copy link
Contributor

bors commented Jul 7, 2024

☀️ Test successful - checks-actions
Approved by: albertlarsan68
Pushing 98dcbae to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 7, 2024
@bors bors merged commit 98dcbae into rust-lang:master Jul 7, 2024
7 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 7, 2024
@Noratrieb Noratrieb mentioned this pull request Jul 7, 2024
Closed
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (98dcbae): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 700.365s -> 699.867s (-0.07%)
Artifact size: 328.48 MiB -> 328.42 MiB (-0.02%)

@Noratrieb Noratrieb mentioned this pull request Jul 7, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 7, 2024
@bors
Auto merge of rust-lang#127455 - Nilstrieb:blazing-tidy, r=jieyouxu
959a2eb 
Make tidy problematic const checking fast again

fixes pathological tidy performance described in rust-lang#127453 by reverting rust-lang#127428

i think anyone can approve this ASAP, it makes working on this repo significantly worse.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GKFX GKFX GKFX left review comments

@albertlarsan68 albertlarsan68 albertlarsan68 approved these changes

Assignees

@albertlarsan68 albertlarsan68

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.81.0
Development

Successfully merging this pull request may close these issues.
7 participants
@donno2048 @rustbot @albertlarsan68 @bors @klensy @rust-timer @GKFX