Use verbose suggestion for ptr::null_mut()
#127391
Conversation
rustbot
added
S-waiting-on-review
|
While I don't mind either the former nor the latter form, could you give a little motivation why? |
|
@cjgillot I'm going through all inline suggestions and moving them to the verbose format whenever possible. I am using that process to audit what the suggestions are and finding some suggestions with bad spans in the process. The original reason to do this is because we want to eventually move to annotate-snippets, which doesn't support inline suggestions. Those suggestions are really a hold over from when structured suggestions had a much worse format than the one we have today. The only inline suggestions that still make some sense are the ones that flat out say to remove or add a token in the right place, almost every other one works better with the new suggestion format or even better with multipart suggestions. |
|
Thanks! |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 3 pull requests Successful merges: - rust-lang#127275 (offset_from, offset: clearly separate safety requirements the user needs to prove from corollaries that automatically follow) - rust-lang#127379 (rustdoc-search: stop constructing pointless arrays in decode) - rust-lang#127391 (Use verbose suggestion for `ptr::null_mut()`) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#127391 - estebank:null_mut, r=cjgillot Use verbose suggestion for `ptr::null_mut()`
No description provided.