Do not define opaque types when selecting impls #126258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
oli-obk
added
the
beta-nominated
|
probably needs to be backported to beta (I think we cut this weekend?) |
lcnr
reviewed
Jun 11, 2024
| @@ -1,10 +1,6 @@ | |||
| // Another example from issue #84660, this time weaponized as a safe transmute: an opaque type in an | |||
| // impl header being accepted was used to create unsoundness. | |||
|
|
|||
| //@ revisions: current next | |||
| //@ ignore-compare-mode-next-solver (explicit revisions) | |||
| //@[next] compile-flags: -Znext-solver | |||
lcnr
reviewed
Jun 11, 2024
| //@ revisions: current next | ||
| //@ ignore-compare-mode-next-solver (explicit revisions) | ||
| //@[next] compile-flags: -Znext-solver | ||
| //@check-pass |
lcnr
reviewed
Jun 11, 2024
| @@ -1,10 +1,6 @@ | |||
| #![feature(type_alias_impl_trait)] | |||
| #![allow(dead_code)] | |||
|
|
|||
| //@ revisions: current next | |||
| //@ ignore-compare-mode-next-solver (explicit revisions) | |||
| //@[next] compile-flags: -Znext-solver | |||
lcnr
reviewed
Jun 11, 2024
… of opaque types." This reverts commit 29a630e.
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup of 5 pull requests Successful merges: - rust-lang#126186 (Migrate `run-make/multiple-emits` to `rmake.rs`) - rust-lang#126236 (Delegation: fix ICE on recursive delegation) - rust-lang#126254 (Remove ignore-cross-compile directive from ui/macros/proc_macro) - rust-lang#126258 (Do not define opaque types when selecting impls) - rust-lang#126265 (interpret: ensure we check bool/char for validity when they are used in a cast) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2024
Rollup merge of rust-lang#126258 - oli-obk:recursive_rpit, r=lcnr Do not define opaque types when selecting impls fixes rust-lang#126117 r? `@lcnr` for inconsistency with next solver
rustbot
added
the
beta-accepted
cuviper
removed
the
beta-nominated
3 tasks
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 14, 2024
[beta] backports and stage0 bump - Bump stage0 to 1.79.0 - Do not define opaque types when selecting impls rust-lang#126258 - Remove failing GUI test to stop blocking CI until it is fixed rust-lang#126445 r? cuviper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #126117
r? @lcnr for inconsistency with next solver