Various Redox OS fixes and add i686 Redox OS target #126192

bjorn3 · 2024-06-09T12:55:15Z

All of these come from the fork used by Redox OS available at https://gitlab.redox-os.org/redox-os/rust/-/commits/redox-2024-05-11/?ref_type=heads.

cc @jackpot51

rustbot · 2024-06-09T12:55:23Z

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2024-06-09T12:55:24Z

These commits modify compiler targets.
(See the Target Tier Policy.)

bjorn3 · 2024-06-09T13:07:55Z

A tier 3 target must have a designated developer or developers (the "target maintainers") on record to be CCed when issues arise regarding the target. (The mechanism to track and CC such developers may evolve over time.)

@jackpot51

Targets must use naming consistent with any existing targets; for instance, a target for the same CPU or OS as an existing Rust target should use the same name for that CPU or OS. Targets should normally use the same names and naming conventions as used elsewhere in the broader ecosystem beyond Rust (such as in other toolchains), unless they have a very good reason to diverge. Changing the name of a target can be highly disruptive, especially once the target reaches a higher tier, so getting the name right is important even for a tier 3 target.

The x86_64 and aarch64 redox targets are named *-unknown-redox too.

Tier 3 targets may have unusual requirements to build or use, but must not create legal issues or impose onerous legal terms for the Rust project or for Rust developers or users.

Redox OS is permissively licensed and uses a regular C toolchain.

Neither this policy nor any decisions made regarding targets shall create any binding agreement or estoppel by any party. If any member of an approving Rust team serves as one of the maintainers of a target, or has any legal or employment requirement (explicit or implicit) that might affect their decisions regarding a target, they must recuse themselves from any approval decisions regarding the target's tier status, though they may otherwise participate in discussions.

Agreed

Tier 3 targets should attempt to implement as much of the standard libraries as possible and appropriate (core for most targets, alloc for targets that can support dynamic memory allocation, std for targets with an operating system or equivalent layer of system-provided functionality), but may leave some code unimplemented (either unavailable or stubbed out as appropriate), whether because the target makes it impossible to implement or challenging to implement. The authors of pull requests are not obligated to avoid calling any portions of the standard library on the basis of a tier 3 target not implementing those portions.

Support should be identical to the existing x86_64 and aarch64 targets.

The target must provide documentation for the Rust community explaining how to build for the target, using cross-compilation if possible. If the target supports running binaries, or running tests (even if they do not pass), the documentation must explain how to run such binaries or tests for the target, using emulation if possible or dedicated hardware if necessary.

Same as x86_64 redox os.

Tier 3 targets must not impose burden on the authors of pull requests, or other developers in the community, to maintain the target. In particular, do not post comments (automated or manual) on a PR that derail or suggest a block on the PR based on a tier 3 target. Do not send automated messages or notifications (via any medium, including via @) to a PR author or others involved with a PR regarding a tier 3 target, unless they have opted into such messages.

Agreed

Patches adding or updating tier 3 targets must not break any existing tier 2 or tier 1 target, and must not knowingly break another tier 3 target without approval of either the compiler team or the maintainers of the other tier 3 target.

Agreed

Tier 3 targets must be able to produce assembly using at least one of rustc's supported backends from any host target.

It does.

src/doc/rustc/src/platform-support.md

rustbot · 2024-06-09T15:51:07Z

Some changes occurred in src/doc/rustc/src/platform-support

cc @Nilstrieb

fee1-dead · 2024-06-12T14:41:33Z

r? compiler

petrochenkov · 2024-06-13T15:20:13Z

@bors r+

bors · 2024-06-13T15:20:16Z

📌 Commit f636d3f has been approved by petrochenkov

It is now in the queue for this repository.

Various Redox OS fixes and add i686 Redox OS target All of these come from the fork used by Redox OS available at https://gitlab.redox-os.org/redox-os/rust/-/commits/redox-2024-05-11/?ref_type=heads. cc `@jackpot51`

…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#125293 (Place tail expression behind terminating scope) - rust-lang#125722 (Indicate in `non_local_defs` lint that the macro needs to change) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126285 (`UniqueRc`: support allocators and `T: ?Sized`.) - rust-lang#126352 (ci: Update centos:7 to use vault repos) - rust-lang#126399 (extend the check for LLVM build) r? `@ghost` `@rustbot` modify labels: rollup

Various Redox OS fixes and add i686 Redox OS target All of these come from the fork used by Redox OS available at https://gitlab.redox-os.org/redox-os/rust/-/commits/redox-2024-05-11/?ref_type=heads. cc ``@jackpot51``

Various Redox OS fixes and add i686 Redox OS target All of these come from the fork used by Redox OS available at https://gitlab.redox-os.org/redox-os/rust/-/commits/redox-2024-05-11/?ref_type=heads. cc `@jackpot51`

bors · 2024-06-16T09:54:28Z

⌛ Testing commit 3bab154 with merge ce82e2b...

bors · 2024-06-16T11:43:07Z

💔 Test failed - checks-actions

* Allow crt-static for dylibs * Pass -lgcc to the linker

Co-Authored-By: Jeremy Soller <jackpot51@gmail.com>

bjorn3 · 2024-06-16T12:58:28Z

Seems like skipping local rebuilds doesn't fix it. I've removed i686-unknown-redox from STAGE0_MISSING_TARGETS for now. Turns out adding new targets here isn't actually necessary.

petrochenkov · 2024-06-16T19:54:17Z

@bors r+

bors · 2024-06-16T19:54:20Z

📌 Commit 742a923 has been approved by petrochenkov

It is now in the queue for this repository.

Rollup of 8 pull requests Successful merges: - rust-lang#126178 (Weekly `cargo update`) - rust-lang#126192 (Various Redox OS fixes and add i686 Redox OS target) - rust-lang#126365 (Honor collapse_debuginfo for statics.) - rust-lang#126524 (bump few deps) - rust-lang#126536 (Remove unused `llvm_readobj.rs` in `run-make-support`) - rust-lang#126546 (std: move `sys_common::backtrace` to `sys`) - rust-lang#126560 (more ice tests) - rust-lang#126561 (`boxed_slice_into_iter`: tiny doc correction) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#126192 - bjorn3:redox_patches, r=petrochenkov Various Redox OS fixes and add i686 Redox OS target All of these come from the fork used by Redox OS available at https://gitlab.redox-os.org/redox-os/rust/-/commits/redox-2024-05-11/?ref_type=heads. cc `@jackpot51`

bors · 2024-06-16T23:32:01Z

⌛ Testing commit 742a923 with merge d7f6eba...

fmease · 2024-06-19T13:40:12Z

@bors retry r-

L3P3 · 2024-09-06T08:48:41Z

compiler/rustc_target/src/spec/targets/i686_unknown_redox.rs

+    Target {
+        llvm_target: "i686-unknown-redox".into(),
+        metadata: crate::spec::TargetMetadata {
+            description: None,


Why no metadata?

The x86_64 target didn't have it either at least when I made this PR.

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [rust](https://github.com/rust-lang/rust) | minor | `1.80.1` -> `1.81.0` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>rust-lang/rust (rust)</summary> ### [`v1.81.0`](https://github.com/rust-lang/rust/blob/HEAD/RELEASES.md#Version-1810-2024-09-05) [Compare Source](rust-lang/rust@1.80.1...1.81.0) \========================== <a id="1.81.0-Language"></a> ## Language - [Abort on uncaught panics in `extern "C"` functions.](rust-lang/rust#116088) - [Fix ambiguous cases of multiple `&` in elided self lifetimes.](rust-lang/rust#117967) - [Stabilize `#[expect]` for lints (RFC 2383),](rust-lang/rust#120924) like `#[allow]` with a warning if the lint is *not* fulfilled. - [Change method resolution to constrain hidden types instead of rejecting method candidates.](rust-lang/rust#123962) - [Bump `elided_lifetimes_in_associated_constant` to deny.](rust-lang/rust#124211) - [`offset_from`: always allow pointers to point to the same address.](rust-lang/rust#124921) - [Allow constraining opaque types during subtyping in the trait system.](rust-lang/rust#125447) - [Allow constraining opaque types during various unsizing casts.](rust-lang/rust#125610) - [Deny keyword lifetimes pre-expansion.](rust-lang/rust#126762) <a id="1.81.0-Compiler"></a> ## Compiler - [Make casts of pointers to trait objects stricter.](rust-lang/rust#120248) - [Check alias args for well-formedness even if they have escaping bound vars.](rust-lang/rust#123737) - [Deprecate no-op codegen option `-Cinline-threshold=...`.](rust-lang/rust#124712) - [Re-implement a type-size based limit.](rust-lang/rust#125507) - [Properly account for alignment in `transmute` size checks.](rust-lang/rust#125740) - [Remove the `box_pointers` lint.](rust-lang/rust#126018) - [Ensure the interpreter checks bool/char for validity when they are used in a cast.](rust-lang/rust#126265) - [Improve coverage instrumentation for functions containing nested items.](rust-lang/rust#127199) - Target changes: - [Add Tier 3 `no_std` Xtensa targets:](rust-lang/rust#125141) `xtensa-esp32-none-elf`, `xtensa-esp32s2-none-elf`, `xtensa-esp32s3-none-elf` - [Add Tier 3 `std` Xtensa targets:](rust-lang/rust#126380) `xtensa-esp32-espidf`, `xtensa-esp32s2-espidf`, `xtensa-esp32s3-espidf` - [Add Tier 3 i686 Redox OS target:](rust-lang/rust#126192) `i686-unknown-redox` - [Promote `arm64ec-pc-windows-msvc` to Tier 2.](rust-lang/rust#126039) - [Promote `loongarch64-unknown-linux-musl` to Tier 2 with host tools.](rust-lang/rust#126298) - [Enable full tools and profiler for LoongArch Linux targets.](rust-lang/rust#127078) - [Unconditionally warn on usage of `wasm32-wasi`.](rust-lang/rust#126662) (see compatibility note below) - Refer to Rust's \[platform support page]\[platform-support-doc] for more information on Rust's tiered platform support. <a id="1.81.0-Libraries"></a> ## Libraries - [Split core's `PanicInfo` and std's `PanicInfo`.](rust-lang/rust#115974) (see compatibility note below) - [Generalize `{Rc,Arc}::make_mut()` to unsized types.](rust-lang/rust#116113) - [Replace sort implementations with stable `driftsort` and unstable `ipnsort`.](rust-lang/rust#124032) All `slice::sort*` and `slice::select_nth*` methods are expected to see significant performance improvements. See the [research project](https://github.com/Voultapher/sort-research-rs) for more details. - [Document behavior of `create_dir_all` with respect to empty paths.](rust-lang/rust#125112) - [Fix interleaved output in the default panic hook when multiple threads panic simultaneously.](rust-lang/rust#127397) <a id="1.81.0-Stabilized-APIs"></a> ## Stabilized APIs - [`core::error`](https://doc.rust-lang.org/stable/core/error/index.html) - [`hint::assert_unchecked`](https://doc.rust-lang.org/stable/core/hint/fn.assert_unchecked.html) - [`fs::exists`](https://doc.rust-lang.org/stable/std/fs/fn.exists.html) - [`AtomicBool::fetch_not`](https://doc.rust-lang.org/stable/core/sync/atomic/struct.AtomicBool.html#method.fetch_not) - [`Duration::abs_diff`](https://doc.rust-lang.org/stable/core/time/struct.Duration.html#method.abs_diff) - [`IoSlice::advance`](https://doc.rust-lang.org/stable/std/io/struct.IoSlice.html#method.advance) - [`IoSlice::advance_slices`](https://doc.rust-lang.org/stable/std/io/struct.IoSlice.html#method.advance_slices) - [`IoSliceMut::advance`](https://doc.rust-lang.org/stable/std/io/struct.IoSliceMut.html#method.advance) - [`IoSliceMut::advance_slices`](https://doc.rust-lang.org/stable/std/io/struct.IoSliceMut.html#method.advance_slices) - [`PanicHookInfo`](https://doc.rust-lang.org/stable/std/panic/struct.PanicHookInfo.html) - [`PanicInfo::message`](https://doc.rust-lang.org/stable/core/panic/struct.PanicInfo.html#method.message) - [`PanicMessage`](https://doc.rust-lang.org/stable/core/panic/struct.PanicMessage.html) These APIs are now stable in const contexts: - [`char::from_u32_unchecked`](https://doc.rust-lang.org/stable/core/char/fn.from_u32\_unchecked.html) (function) - [`char::from_u32_unchecked`](https://doc.rust-lang.org/stable/core/primitive.char.html#method.from_u32\_unchecked) (method) - [`CStr::count_bytes`](https://doc.rust-lang.org/stable/core/ffi/c_str/struct.CStr.html#method.count_bytes) - [`CStr::from_ptr`](https://doc.rust-lang.org/stable/core/ffi/c_str/struct.CStr.html#method.from_ptr) <a id="1.81.0-Cargo"></a> ## Cargo - [Generated `.cargo_vcs_info.json` is always included, even when `--allow-dirty` is passed.](rust-lang/cargo#13960) - [Disallow `package.license-file` and `package.readme` pointing to non-existent files during packaging.](rust-lang/cargo#13921) - [Disallow passing `--release`/`--debug` flag along with the `--profile` flag.](rust-lang/cargo#13971) - [Remove `lib.plugin` key support in `Cargo.toml`. Rust plugin support has been deprecated for four years and was removed in 1.75.0.](rust-lang/cargo#13902) <a id="1.81.0-Compatibility-Notes"></a> ## Compatibility Notes - Usage of the `wasm32-wasi` target will now issue a compiler warning and request users switch to the `wasm32-wasip1` target instead. Both targets are the same, `wasm32-wasi` is only being renamed, and this [change to the WASI target](https://blog.rust-lang.org/2024/04/09/updates-to-rusts-wasi-targets.html) is being done to enable removing `wasm32-wasi` in January 2025. - We have renamed `std::panic::PanicInfo` to `std::panic::PanicHookInfo`. The old name will continue to work as an alias, but will result in a deprecation warning starting in Rust 1.82.0. `core::panic::PanicInfo` will remain unchanged, however, as this is now a *different type*. The reason is that these types have different roles: `std::panic::PanicHookInfo` is the argument to the [panic hook](https://doc.rust-lang.org/stable/std/panic/fn.set_hook.html) in std context (where panics can have an arbitrary payload), while `core::panic::PanicInfo` is the argument to the [`#[panic_handler]`](https://doc.rust-lang.org/nomicon/panic-handler.html) in no_std context (where panics always carry a formatted *message*). Separating these types allows us to add more useful methods to these types, such as `std::panic::PanicHookInfo::payload_as_str()` and `core::panic::PanicInfo::message()`. - The new sort implementations may panic if a type's implementation of [`Ord`](https://doc.rust-lang.org/std/cmp/trait.Ord.html) (or the given comparison function) does not implement a [total order](https://en.wikipedia.org/wiki/Total_order) as the trait requires. `Ord`'s supertraits (`PartialOrd`, `Eq`, and `PartialEq`) must also be consistent. The previous implementations would not "notice" any problem, but the new implementations have a good chance of detecting inconsistencies, throwing a panic rather than returning knowingly unsorted data. - [In very rare cases, a change in the internal evaluation order of the trait solver may result in new fatal overflow errors.](rust-lang/rust#126128) <a id="1.81.0-Internal-Changes"></a> ## Internal Changes These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Add a Rust-for Linux `auto` CI job to check kernel builds.](rust-lang/rust#125209) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

rustbot assigned fee1-dead Jun 9, 2024

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the redox_patches branch from 531c1a9 to f3ceb5e Compare June 9, 2024 13:03

This comment has been minimized.

Sign in to view

bjorn3 force-pushed the redox_patches branch from f3ceb5e to db45105 Compare June 9, 2024 13:13

jackpot51 approved these changes Jun 9, 2024

View reviewed changes

Urgau reviewed Jun 9, 2024

View reviewed changes

src/doc/rustc/src/platform-support.md Outdated Show resolved Hide resolved

rustbot assigned petrochenkov and unassigned fee1-dead Jun 12, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 13, 2024

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 6 pull requests #126461

Closed

matthiaskrgr mentioned this pull request Jun 14, 2024

Rollup of 5 pull requests #126465

Closed

This comment was marked as resolved.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 14, 2024

bjorn3 force-pushed the redox_patches branch from f636d3f to 3b8cda5 Compare June 14, 2024 11:45

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 16, 2024

This comment has been minimized.

Sign in to view

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 16, 2024

jackpot51 and others added 4 commits June 16, 2024 12:56

Several fixes to the redox target specs

60a972d

* Allow crt-static for dylibs * Pass -lgcc to the linker

Add i686-unknown-redox target

efa213a

Co-Authored-By: Jeremy Soller <jackpot51@gmail.com>

Use Linux file locking on Redox

3cddc04

Add dedicated platform support page for Redox OS

742a923

bjorn3 force-pushed the redox_patches branch from 3bab154 to 742a923 Compare June 16, 2024 12:57

bjorn3 mentioned this pull request Jun 16, 2024

Complete tier 3 target information #126451

Open

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 16, 2024

jieyouxu mentioned this pull request Jun 16, 2024

Rollup of 8 pull requests #126563

Merged

bors merged commit a033dab into rust-lang:master Jun 16, 2024
6 checks passed

rustbot added this to the 1.81.0 milestone Jun 16, 2024

bjorn3 deleted the redox_patches branch June 17, 2024 08:39

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 19, 2024

L3P3 reviewed Sep 6, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Various Redox OS fixes and add i686 Redox OS target #126192

Various Redox OS fixes and add i686 Redox OS target #126192

bjorn3 commented Jun 9, 2024

rustbot commented Jun 9, 2024

rustbot commented Jun 9, 2024

This comment has been minimized.

bjorn3 commented Jun 9, 2024

This comment has been minimized.

rustbot commented Jun 9, 2024

fee1-dead commented Jun 12, 2024

petrochenkov commented Jun 13, 2024

bors commented Jun 13, 2024

This comment was marked as resolved.

bors commented Jun 16, 2024

This comment has been minimized.

bors commented Jun 16, 2024

bjorn3 commented Jun 16, 2024

petrochenkov commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

fmease commented Jun 19, 2024

L3P3 Sep 6, 2024

bjorn3 Sep 8, 2024

Various Redox OS fixes and add i686 Redox OS target #126192

Various Redox OS fixes and add i686 Redox OS target #126192

Conversation

bjorn3 commented Jun 9, 2024

rustbot commented Jun 9, 2024

rustbot commented Jun 9, 2024

This comment has been minimized.

bjorn3 commented Jun 9, 2024

This comment has been minimized.

rustbot commented Jun 9, 2024

fee1-dead commented Jun 12, 2024

petrochenkov commented Jun 13, 2024

bors commented Jun 13, 2024

This comment was marked as resolved.

bors commented Jun 16, 2024

This comment has been minimized.

bors commented Jun 16, 2024

bjorn3 commented Jun 16, 2024

petrochenkov commented Jun 16, 2024

bors commented Jun 16, 2024

bors commented Jun 16, 2024

fmease commented Jun 19, 2024

L3P3 Sep 6, 2024

Choose a reason for hiding this comment

bjorn3 Sep 8, 2024

Choose a reason for hiding this comment