Remove empty test suite tests/run-make-fulldeps
#126155
Conversation
|
r? @onur-ozkan rustbot has assigned @onur-ozkan. Use |
rustbot
added
A-testsuite
|
Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
| ENV SCRIPT \ | ||
| python3 ../x.py --stage 2 build && \ | ||
| python3 ../x.py --stage 2 test tests/run-make-fulldeps --test-args clang |
There was a problem hiding this comment.
This one is a bit of a head-scratcher for me, because with the removal of run-make-fulldeps it's unclear to me what this job is actually supposed to be testing.
(But I'm also not very familiar with how these Dockerfiles are used.)
There was a problem hiding this comment.
Hmm, this image wasn't actually running any useful tests for some time, because there were no tests marked with needs-matching-clang left in the run-make-fulldeps directory.
There was a problem hiding this comment.
I think that we should just change this invocation to tests/run-make, for now. In the longer term, I'm planning to document and inspect all our CI jobs to make sure that we don't miss any tests, and that we don't do useless work, because apparently some of them are very old :)
There was a problem hiding this comment.
Looking at the history of this job, I think it was originally intended to just build the compiler with --enable-debug, to check that the build succeeds.
Then the clang-specific stuff was grafted on later.
There was a problem hiding this comment.
But since the clang-specific stuff has been moved over into run-make (#109770), replacing this with run-make still makes sense, probably.
Zalathar
force-pushed
the
run-make-fulldeps
branch
from
133a403
to
0a258af
Compare
There was a problem hiding this comment.
Looks good to me, thanks!
r=me once #126155 (comment) is addressed.
This test never actually checked anything useful, so presumably it only existed to silence the tidy check for feature gate tests, with the real checks being performed elsewhere (in tests that have since been deleted).
Zalathar
force-pushed
the
run-make-fulldeps
branch
3 times, most recently
from
8a3067f
to
0bdc68d
Compare
|
I made the suggested changes to Note that I have removed the |
|
I've also set up a run of the debug job over in #114917, because it looks like some of the affected tests haven't actually been running for a while, so I want to see whether any of them fail. |
|
Looks like my test run found some tests that are broken: In light of this, I'll update the Dockerfile to continue passing |
Zalathar
force-pushed
the
run-make-fulldeps
branch
from
0bdc68d
to
1131680
Compare
It looks like this job was intending to run all of the `needs-matching-clang` tests (since they don't run without `RUSTBUILD_FORCE_CLANG_BASED_TESTS`), but over time developed two problems: - The tests it cares about were moved from run-make-fulldeps to run-make. - Some of the relevant tests don't actually have "clang" in their name. Switching to run-make solves the first problem, but we still don't run the tests without "clang" in their name, because some of them are currently broken.
Zalathar
force-pushed
the
run-make-fulldeps
branch
from
1131680
to
5223bf4
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#126137 (tests: Add ui/higher-ranked/trait-bounds/normalize-generic-arg.rs) - rust-lang#126146 (std::unix::process adding few specific freebsd signals to be able to id.) - rust-lang#126155 (Remove empty test suite `tests/run-make-fulldeps`) - rust-lang#126168 (std::unix::os current_exe implementation simplification for haiku.) - rust-lang#126175 (Use --quiet flag when installing pip dependencies) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#126155 - Zalathar:run-make-fulldeps, r=onur-ozkan Remove empty test suite `tests/run-make-fulldeps` After rust-lang#109770, there were only a handful of tests left in the run-make-fulldeps suite. As of rust-lang#126111, there are no longer *any* run-make-fulldeps tests, so now we can: - Remove the directory - Remove related bootstrap/compiletest code - Remove various other references in CI scripts and documentation. By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to [rmake](rust-lang#121876) (or whether rmake even works with fulldeps).
After #109770, there were only a handful of tests left in the run-make-fulldeps suite.
As of #126111, there are no longer any run-make-fulldeps tests, so now we can:
By removing this suite, we also no longer need to worry about discrepancies between it and ui-fulldeps, and we don't have to worry about porting tests from Makefile to rmake (or whether rmake even works with fulldeps).