Spell out other trait diagnostic #126127
Merged
Spell out other trait diagnostic #126127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I think the diagnostic output here is meant to be indicative of the UFCS form: https://doc.rust-lang.org/reference/expressions/call-expr.html#disambiguating-function-calls I'd be hestitant to rewrite this output without weighing that tradeoff |
|
|
|
fair enough @bors r+ rollup |
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jun 12, 2024
…elix Spell out other trait diagnostic I recently saw somebody confused about the diagnostic thinking it was suggesting to add an `as` cast. This change is longer but I think it's clearer
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 12, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#123374 (DOC: Add FFI example for slice::from_raw_parts()) - rust-lang#126127 (Spell out other trait diagnostic) - rust-lang#126228 (Provide correct parent for nested anon const) - rust-lang#126249 (Simplify `[T; N]::try_map` signature) - rust-lang#126256 (Add {{target}} substitution to compiletest) - rust-lang#126263 (Make issue-122805.rs big endian compatible) r? `@ghost` `@rustbot` modify labels: rollup
|
failed in #126297 (comment) it seems @bors r- |
bors
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
rust-cloud-vms
bot
force-pushed
the
other-trait-diag
branch
from
79dd1ca
to
d0112c6
Compare
|
Rebased to cover the new test cases |
|
@bors r=pnkfelix |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 16, 2024
Rollup of 4 pull requests Successful merges: - rust-lang#125112 (Document behavior of `create_dir_all` wrt. empty path) - rust-lang#126127 (Spell out other trait diagnostic) - rust-lang#126309 (unify git command preperation) - rust-lang#126539 (Update `Arc::try_unwrap()` docs) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 16, 2024
Rollup merge of rust-lang#126127 - Alexendoo:other-trait-diag, r=pnkfelix Spell out other trait diagnostic I recently saw somebody confused about the diagnostic thinking it was suggesting to add an `as` cast. This change is longer but I think it's clearer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently saw somebody confused about the diagnostic thinking it was suggesting to add an
ascast. This change is longer but I think it's clearer