Port tests/run-make-fulldeps/issue-19371 to ui-fulldeps
#126008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
jieyouxu
approved these changes
Jun 5, 2024
|
@bors delegate+ |
|
CI is green, but I’ll be shocked if this doesn’t fail somewhere in the full job matrix. @bors r=jieyouxu rollup=iffy |
|
🌲 The tree is currently closed for pull requests below priority 101. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
I also have patches for the other remaining |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#124840 (resolve: mark it undetermined if single import is not has any bindings) - rust-lang#125622 (Winnow private method candidates instead of assuming any candidate of the right name will apply) - rust-lang#125648 (Remove unused(?) `~/rustsrc` folder from docker script) - rust-lang#125672 (Add more ABI test cases to miri (RFC 3391)) - rust-lang#125800 (Fix `mut` static task queue in SGX target) - rust-lang#125871 (Orphanck[old solver]: Consider opaque types to never cover type parameters) - rust-lang#125893 (Handle all GVN binops in a single place.) - rust-lang#126008 (Port `tests/run-make-fulldeps/issue-19371` to ui-fulldeps) - rust-lang#126032 (Update description of the `IsTerminal` example) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2024
Rollup merge of rust-lang#126008 - Zalathar:fulldeps-19371, r=jieyouxu Port `tests/run-make-fulldeps/issue-19371` to ui-fulldeps This test can run as an ordinary `tests/ui-fulldeps` test, with the help of some additional header variable substitutions to supply a sysroot and linker. --- Unlike rust-lang#125973, this test appears to be testing something vaguely useful and breakable, which is why I didn't just delete it.
This was referenced Jun 6, 2024
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 6, 2024
…ouxu
Port `tests/run-make-fulldeps/obtain-borrowck` to ui-fulldeps
Thanks to `{{sysroot-base}}` from rust-lang#126008, this was also pretty straightforward to port over.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jun 6, 2024
…ouxu
Port `tests/run-make-fulldeps/obtain-borrowck` to ui-fulldeps
Thanks to `{{sysroot-base}}` from rust-lang#126008, this was also pretty straightforward to port over.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jun 6, 2024
…ouxu
Port `tests/run-make-fulldeps/obtain-borrowck` to ui-fulldeps
Thanks to `{{sysroot-base}}` from rust-lang#126008, this was also pretty straightforward to port over.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 7, 2024
Rollup merge of rust-lang#126073 - Zalathar:fulldeps-borrowck, r=jieyouxu Port `tests/run-make-fulldeps/obtain-borrowck` to ui-fulldeps Thanks to `{{sysroot-base}}` from rust-lang#126008, this was also pretty straightforward to port over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can run as an ordinary
tests/ui-fulldepstest, with the help of some additional header variable substitutions to supply a sysroot and linker.Unlike #125973, this test appears to be testing something vaguely useful and breakable, which is why I didn't just delete it.