Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 8 pull requests #125592

Closed
wants to merge 17 commits into from
Closed

Rollup of 8 pull requests #125592

wants to merge 17 commits into from

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented May 26, 2024

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

veera-sivarajan and others added 17 commits April 16, 2024 18:15
@veera-sivarajan
Update Tests
62a104d
@veera-sivarajan
Support C23's Variadics Without a Named Parameter
f005b45 
This PR removes the static check that disallowed extern functions
with ellipsis (varargs) as the only parameter since this is now
valid in C23.

Also, adds a doc comment for `check_decl_cvariadic_pos()` and
fixes the name of the function (`varadic` -> `variadic`).
@bjorn3
Only allow immutable statics with #[linkage]
531dae1
@compiler-errors
Don't skip inner const when looking for body for suggestion
c58b7c9
@SparrowLii
cleanup dependence of ExtCtxt in transcribe when macro expansion
2782123
@matthiaskrgr
crashes: increment the number of tracked ones
ce67768
@Urgau
Also mention my-self for check-cfg docs changes
bebcb4e
@camelid
Notify T-rustdoc for beta-accepted and stable-accepted too
91b3ef5 
Otherwise, it's unclear when the nomination label is removed whether the
backport was accepted, thus nomination removed, or if the backport was
rejected, thus nomination removed.
@scottmcm
Avoid a FieldIdx::from_usize in InstSimplify
d37f456
@jhpratt
Rollup merge of rust-lang#124048 - veera-sivarajan:bugfix-123773-c23-…
ec0d36b 
…variadics, r=compiler-errors

Support C23's Variadics Without a Named Parameter

Fixes rust-lang#123773

This PR removes the static check that disallowed extern functions
with ellipsis (varargs) as the only parameter since this is now
valid in C23.

This will not break any existing code as mentioned in the proposal
document: https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2975.pdf.

Also, adds a doc comment for `check_decl_cvariadic_pos()` and
fixes the name of the function (`varadic` -> `variadic`).
@jhpratt
Rollup merge of rust-lang#125046 - bjorn3:no_mutable_static_linkage, …
0996b74 
…r=cjgillot

Only allow immutable statics with #[linkage]
@jhpratt
Rollup merge of rust-lang#125469 - compiler-errors:dont-skip-inner-co…
5c24222 
…nst-body, r=cjgillot

Don't skip out of inner const when looking for body for suggestion

Self-explanatory title, I'll point out the important logic in an inline comment.

Fixes rust-lang#125370
@jhpratt
Rollup merge of rust-lang#125530 - SparrowLii:expand2, r=petrochenkov
8bcf07e 
cleanup dependence of `ExtCtxt` in transcribe when macro expansion

part of rust-lang#125356
We can remove `transcribe`’s dependence on `ExtCtxt` to facilitate subsequent work (such as moving macro expansion into the incremental compilation system)

r? ``@petrochenkov``
Thanks for the reviewing!
@jhpratt
Rollup merge of rust-lang#125539 - matthiaskrgr:cräsh, r=jieyouxu
a57926a 
crashes: increment the number of tracked ones

r? ```@jieyouxu```
@jhpratt
Rollup merge of rust-lang#125544 - Urgau:check-cfg-mention-cargo-spec…
8ba8b65 
…ific, r=jieyouxu

Also mention my-self for other check-cfg docs changes

This PR adds a mention for my-self for the recently added `src/doc/rustc/src/check-cfg` directory.

*I had to add a second mention just for the directory since [`Path::starts_with`](https://doc.rust-lang.org/std/path/struct.Path.html#method.starts_with) as used by [triagebot](https://github.com/rust-lang/triagebot/blob/48f29f351cae774caa90f555fbbc6d0df7dce80e/src/handlers/mentions.rs#L69), matches on path components and so can never return true for a file and directory at the same time.*
@jhpratt
Rollup merge of rust-lang#125566 - camelid:notify-accepted, r=Guillau…
94583a4 
…meGomez

Notify T-rustdoc for beta-accepted and stable-accepted too

Otherwise, it's unclear when the nomination label is removed whether the backport was accepted, thus nomination removed, or if the backport was rejected, thus nomination removed.

r? ```@GuillaumeGomez```
@jhpratt
Rollup merge of rust-lang#125582 - scottmcm:less-from-usize, r=jieyouxu
75b0523 
Avoid a `FieldIdx::from_usize` in InstSimplify

Just a tiny cleanup I noticed in passing while looking at something unrelated.
@rustbot rustbot added A-meta Area: Issues about the rust-lang/rust repository. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels May 26, 2024
@jhpratt
Copy link
Member Author

jhpratt commented May 26, 2024

@bors r+ rollup=never p=8

@bors
Copy link
Contributor

bors commented May 26, 2024

📌 Commit 75b0523 has been approved by jhpratt

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 26, 2024
@workingjubilee
Copy link
Member

We should not be going forward with a rollup which tracks a crash over one that fixes it:

@jieyouxu
Copy link
Member

Lol sorry I didn't notice they were in the same rollup

@jhpratt
Copy link
Member Author

jhpratt commented May 26, 2024

🤦 I have no idea how I missed that. I'll let someone else redo this, as I have other things to do at the moment lol

@bors r-

@jhpratt jhpratt closed this May 26, 2024
@jhpratt jhpratt deleted the rollup-5h5u413 branch May 26, 2024 22:26
@workingjubilee
Copy link
Member

Remaking

@workingjubilee
Copy link
Member

roll-up: #125593

@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
#16 exporting to docker image format
#16 sending tarball 28.3s done
#16 DONE 41.6s
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.thin-lto-import-instr-limit := 10
configure: change-id            := 99999999
---

running 227 tests
........................................................................................  88/227
........................................................................................ 176/227
....................2024-05-26T22:37:56.167198Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/125520.rs ... F
[crashes] tests/crashes/125520.rs ... F
........................2024-05-26T22:37:56.726593Z ERROR compiletest::runtest: fatal error, panic: "test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit."
[crashes] tests/crashes/125370.rs ... F
.....

failures:
failures:

---- [crashes] tests/crashes/125520.rs stdout ----

error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125520.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

---- [crashes] tests/crashes/125370.rs stdout ----


error: test no longer crashes/triggers ICE! Please give it a mearningful name, add a doc-comment to the start of the test explaining why it exists and move it to tests/ui or wherever you see fit.
thread '[crashes] tests/crashes/125370.rs' panicked at src/tools/compiletest/src/runtest.rs:2830:9:


failures:
    [crashes] tests/crashes/125520.rs

@workingjubilee workingjubilee mentioned this pull request May 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-meta Area: Issues about the rust-lang/rust repository. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.