Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restate GlobalAlloc method safety preconditions in terms of what the caller has to do for greater clarity #123932

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

restate GlobalAlloc method safety preconditions in terms of what the caller has to do for greater clarity #123932

wants to merge 1 commit into from
+17 −15

Conversation

adamse
Copy link
Contributor

@adamse adamse commented Apr 14, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2024

r? @m-ou-se

rustbot has assigned @m-ou-se.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 14, 2024
@tgross35
Copy link
Contributor

@rustbot author

Thanks for these changes, a few suggestions. Just comment @rustbot ready when you are all set.

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024
@tgross35 tgross35 assigned tgross35 and unassigned m-ou-se Jul 16, 2024
@bors
Copy link
Contributor

bors commented Jul 28, 2024

☔ The latest upstream changes (presumably #128313) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Member

@adamse any updates on this? thanks

@adamse
Copy link
Contributor Author

adamse commented Aug 14, 2024

will take another look next week.

@adamse adamse force-pushed the global-alloc-safety-preconds-positive branch from c2452e8 to 896ccaa Compare September 7, 2024 14:22
@adamse
Copy link
Contributor Author

adamse commented Sep 7, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachs18 zachs18 zachs18 left review comments

@tgross35 tgross35 tgross35 left review comments

Assignees

@tgross35 tgross35

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamse @rustbot @tgross35 @bors @Dylan-DPC @zachs18 @m-ou-se