Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls

[oli-obk]

fixes #123292

Also removes a bunch of extra diagnostics that were introduced in #121154 and #120558

[rustbot]

r? @estebank

rustbot has assigned @estebank.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[oli-obk]

@bors try @rust-timer queue

[bors]

⌛ Trying commit c0a9c8c with merge f78ee34...

[bors]

☀️ Try build successful - checks-actions
Build commit: f78ee34 (f78ee3493e18d9629e211c9eda272ade79bfa4bb)

[compiler-errors]

r=me if perf is fine

[compiler-errors]

@rustbot author

[rust-timer]

Finished benchmarking commit (f78ee34): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-3.7%	[-5.2%, -2.3%]	2
All ❌✅ (primary)	-3.1%	[-3.1%, -3.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.151s -> 675.22s (0.46%)
Artifact size: 318.39 MiB -> 318.39 MiB (0.00%)

[estebank]

@bors r+

[bors]

📌 Commit c0a9c8c has been approved by estebank

It is now in the queue for this repository.

[bors]

⌛ Testing commit c0a9c8c with merge 5a51958...

[bors]

⌛ Testing commit c0a9c8c with merge 00ed4ed...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 00ed4ed to master...

[rust-timer]

Finished benchmarking commit (00ed4ed): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.5%	[-0.9%, -0.4%]	7
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.2%	[-1.2%, -1.2%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.7%, -2.2%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 679.119s -> 677.217s (-0.28%)
Artifact size: 316.14 MiB -> 316.08 MiB (-0.02%)