Beta revert "Use OS thread name by default" #123533
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts rust-lang#121666 due to rust-lang#123495 This has already been done on master but beta needs something that will backport cleanly.
ChrisDenton
added
the
beta-nominated
|
rustbot
added
O-hermit
Amanieu
added
the
beta-accepted
Merged
cuviper
removed
the
beta-nominated
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
[beta] backports - fix attribute validation on associated items in traits rust-lang#121545 - Only inspect user-written predicates for privacy concerns rust-lang#123377 - Check def id before calling `match_projection_projections` rust-lang#123471 - Restore `pred_known_to_hold_modulo_regions` rust-lang#123578 - Beta revert "Use OS thread name by default" rust-lang#123533 r? cuviper
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2024
[beta] backports - fix attribute validation on associated items in traits rust-lang#121545 - Only inspect user-written predicates for privacy concerns rust-lang#123377 - Check def id before calling `match_projection_projections` rust-lang#123471 - Restore `pred_known_to_hold_modulo_regions` rust-lang#123578 - Beta revert "Use OS thread name by default" rust-lang#123533 r? cuviper
|
Merged in #123801. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts #121666 due to #123495.
In summary, this comment was not upheld:
rust/library/std/src/thread/mod.rs
Line 1252 in d009f60
This has already been reverted on master but that PR can't be backported to beta without modification so I've created a new PR for the beta nomination.
r? Mark-Simulacrum