-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downgrade const eval dangling ptr in final to future incompat lint #122204
Merged
bors
merged 9 commits into
rust-lang:master
from
pnkfelix:downgrade-const-eval-dnagling-ptr-in-final-to-future-incompat-lint
Mar 14, 2024
Merged
Downgrade const eval dangling ptr in final to future incompat lint #122204
bors
merged 9 commits into
rust-lang:master
from
pnkfelix:downgrade-const-eval-dnagling-ptr-in-final-to-future-incompat-lint
Mar 14, 2024
Commits on Mar 13, 2024
-
downgrade mutable-ptr-in-final-value from hard-error to future-incomp…
…at lint to address issue 121610.
Configuration menu - View commit details
-
Copy full SHA for a8549b4 - Browse repository at this point
Copy the full SHA a8549b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f86b46a - Browse repository at this point
Copy the full SHA f86b46aView commit details -
Added
deny(const_eval_mutable_ptr_in_final_value)
attribute to all ……tests that were expecting the hard error for it. I attempted to do this in a manner that preserved the line numbers to reduce the review effort on the resulting diff, but we still have to deal with the ramifications of how a future-incompat lint behaves compared to a hard-error (in terms of its impact on the diagnostic output).
Configuration menu - View commit details
-
Copy full SHA for 1c3424b - Browse repository at this point
Copy the full SHA 1c3424bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ca46da - Browse repository at this point
Copy the full SHA 6ca46daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 354c41e - Browse repository at this point
Copy the full SHA 354c41eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae374cf - Browse repository at this point
Copy the full SHA ae374cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ea091a - Browse repository at this point
Copy the full SHA 1ea091aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c33cc6 - Browse repository at this point
Copy the full SHA 9c33cc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8f45a9e - Browse repository at this point
Copy the full SHA 8f45a9eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.