Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Remove the final span-merge pass, and rename is_closure to is_hole #121433

Closed
wants to merge 4 commits into from
Closed

coverage: Remove the final span-merge pass, and rename is_closure to is_hole #121433

wants to merge 4 commits into from

Commits on Feb 23, 2024

  1. coverage: Remove some lingering references to pending_dups

    @Zalathar
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    4e922eb View commit details
    Browse the repository at this point in the history

  2. coverage: Remove the final merge pass after span refinement 

    This step used to be essential, but after other recent changes to span
refinement it doesn't appear to be particularly necessary.

Removing the final merge step will make it easier to simplify or replace the
span refinement code.
    @Zalathar
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    14c22e3 View commit details
    Browse the repository at this point in the history

  3. coverage: Closure spans don't need to become refined spans 

    Now that we don't perform a final merge pass on refined spans, there's no need
to create refined spans for closure/hole spans, so we can just discard them
immediately.
    @Zalathar
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f380bd7 View commit details
    Browse the repository at this point in the history

  4. coverage: Rename is_closure to is_hole 

    When refining covspans, we don't specifically care which ones represent
closures; we just want to know which ones represent "holes" that should be
carved out of other spans and then discarded.

(Closures are currently the only source of hole spans, but in the future we
might want to also create hole spans for nested items and inactive `#[cfg(..)]`
regions.)
    @Zalathar
    Zalathar committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    303c333 View commit details
    Browse the repository at this point in the history