Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #121142

Merged
merged 25 commits into from
Feb 15, 2024
Merged

Rollup of 8 pull requests #121142

merged 25 commits into from
Feb 15, 2024

Commits on Jan 28, 2024

  1. Configuration menu
    Copy the full SHA
    57e0dea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d4adb3a View commit details
    Browse the repository at this point in the history
  3. Tidy up

    udoprog committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    23c83fa View commit details
    Browse the repository at this point in the history
  4. Fix doctest

    udoprog committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    d63384d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    eebc720 View commit details
    Browse the repository at this point in the history
  6. Fix doctest

    udoprog committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    bdbbf04 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. Fix BTreeMap's Cursor::remove_{next,prev}

    These would incorrectly leave `current` as `None` after a failed attempt
    to remove an element (due to the cursor already being at the start/end).
    Amanieu committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    adb7607 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. std::thread update freebsd stack guard handling.

    up to now, it had been assumed the stack guard setting default is not
    touched in the field but some user might just want to disable it or
    increase it. checking it once at runtime should be enough.
    devnexen committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    6686ca0 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2024

  1. Implicitly enable evex512 if avx512 is enabled

    LLVM 18 requires the evex512 feature to allow use of zmm registers.
    LLVM automatically sets it when using a generic CPU, but not when
    `-C target-cpu` is specified. This will result either in backend
    legalization crashes, or code unexpectedly using ymm instead of
    zmm registers.
    
    For now, make sure that `avx512*` features imply `evex512`. Long
    term we'll probably have to deal with the AVX10 mess somehow.
    nikic committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    369fff6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ddec8c5 View commit details
    Browse the repository at this point in the history
  3. Fix msg for verbose suggestions with confusable capitalization

    When encountering a verbose/multipart suggestion that has changes
    that are only caused by different capitalization of ASCII letters that have
    little differenciation, expand the message to highlight that fact (like we
    already do for inline suggestions).
    
    The logic to do this was already present, but implemented incorrectly.
    estebank committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8d4d572 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c1bb352 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2024

  1. Remove LitError::LexerError.

    `cook_lexer_literal` can emit an error about an invalid int literal but
    then return a non-`Err` token. And then `integer_lit` has to account for
    this to avoid printing a redundant error message.
    
    This commit changes `cook_lexer_literal` to return `Err` in that case.
    Then `integer_lit` doesn't need the special case, and
    `LitError::LexerError` can be removed.
    nnethercote committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    8b35f8e View commit details
    Browse the repository at this point in the history
  2. Make report_lit_error return ErrorGuaranteed.

    This will be helpful for subsequent commits.
    nnethercote committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    a513bb2 View commit details
    Browse the repository at this point in the history
  3. Make emit_unescape_error return Option<ErrorGuaranteed>.

    And use the result in `cook_common` to decide whether to return an error
    token.
    nnethercote committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    332c577 View commit details
    Browse the repository at this point in the history
  4. Add ErrorGuaranteed to ast::LitKind::Err, token::LitKind::Err.

    This mostly works well, and eliminates a couple of delayed bugs.
    
    One annoying thing is that we should really also add an
    `ErrorGuaranteed` to `proc_macro::bridge::LitKind::Err`. But that's
    difficult because `proc_macro` doesn't have access to `ErrorGuaranteed`,
    so we have to fake it.
    nnethercote committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    25ed6e4 View commit details
    Browse the repository at this point in the history
  5. Add suffixes to LitError.

    To avoid some unwrapping.
    nnethercote committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    ac47f6c View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#120449 - udoprog:document-unsized-rc-arc-fr…

    …om-raw, r=m-ou-se
    
    Document requirements for unsized {Rc,Arc}::from_raw
    
    This seems to be implied due to these types supporting operation-less unsized coercions. Taken together with the [established behavior of a wide to thin pointer cast](rust-lang/reference#1451) it would enable unsafe downcasting of these containers.
    
    Note that the term "data pointer" is adopted from rust-lang/rfcs#3559
    
    See also this [internals thread](https://internals.rust-lang.org/t/can-unsafe-smart-pointer-downcasts-be-correct/20229/2).
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    9fdab38 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#120505 - Amanieu:fix-btreemap-cursor-remove…

    …, r=m-ou-se
    
    Fix BTreeMap's Cursor::remove_{next,prev}
    
    These would incorrectly leave `current` as `None` after a failed attempt to remove an element (due to the cursor already being at the start/end).
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    472c820 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#120672 - devnexen:update_thread_stack_guard…

    …pages_fbsd, r=m-ou-se
    
    std::thread update freebsd stack guard handling.
    
    up to now, it had been assumed the stack guard setting default is not touched in the field but some user might just want to disable it or increase it. checking it once at runtime should be enough.
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    bf323ba View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#121088 - nikic:evex512, r=Amanieu

    Implicitly enable evex512 if avx512 is enabled
    
    LLVM 18 requires the evex512 feature to allow use of zmm registers. LLVM automatically sets it when using a generic CPU, but not when `-C target-cpu` is specified. This will result either in backend legalization crashes, or code unexpectedly using ymm instead of zmm registers.
    
    For now, make sure that `avx512*` features imply `evex512`. Long term we'll probably have to deal with the AVX10 mess somehow.
    
    Fixes rust-lang#121081.
    
    r? `@Amanieu`
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    7d6c99d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#121104 - Urgau:bigger_layout-fix-fp, r=comp…

    …iler-errors
    
    Ignore unsized types when trying to determine the size of the original type
    
    Fixes rust-lang#121074 a regression from rust-lang#118983
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    12d70af View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#121107 - estebank:capitalization-suggestion…

    …, r=michaelwoerister
    
    Fix msg for verbose suggestions with confusable capitalization
    
    When encountering a verbose/multipart suggestion that has changes that are only caused by different capitalization of ASCII letters that have little differenciation, expand the message to highlight that fact (like we already do for inline suggestions).
    
    The logic to do this was already present, but implemented incorrectly.
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    3c87054 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#121113 - oli-obk:track_errors10, r=compiler…

    …-errors
    
    Continue compilation even if inherent impl checks fail
    
    We should not be hiding errors behind unrelated errors
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    e878439 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#121120 - nnethercote:LitKind-Err-guar, r=fm…

    …ease
    
    Add `ErrorGuaranteed` to `ast::LitKind::Err`, `token::LitKind::Err`.
    
    Similar to recent work doing the same for `ExprKind::Err` (rust-lang#120586) and `TyKind::Err` (rust-lang#121109).
    
    r? `@oli-obk`
    GuillaumeGomez committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    06f53dd View commit details
    Browse the repository at this point in the history