Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adapt test for v0 symbol mangling #120310

Merged
merged 1 commit into from
Jan 30, 2024
Merged

adapt test for v0 symbol mangling #120310

merged 1 commit into from
Jan 30, 2024

Conversation

krasimirgg
Copy link
Contributor

@krasimirgg krasimirgg commented Jan 24, 2024 •
edited
Loading

No functional changes intended.

Adapts the test to also work under new-symbol-mangling = true.

@krasimirgg
adapt test for v0 symbol mangling
e23937c 
No functional changes intended.

Adapts the test to also work under new-symbol-mangling = true.
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2024

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 24, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 24, 2024

Error: Parsing assign command in comment failed: ...':' | error: specify user to assign to at >| ' @nikic'...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

Teapot4195
Teapot4195 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@Teapot4195 Teapot4195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (here's a case where it would be convenient to have r+ perms)

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 27, 2024

📌 Commit e23937c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 27, 2024
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jan 30, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2024
@bors
Auto merge of rust-lang#120496 - GuillaumeGomez:rollup-fmu9jre, r=Gui…
f3d71c9 
…llaumeGomez

Rollup of 11 pull requests

Successful merges:

 - rust-lang#117906 (Improve display of crate name when hovered)
 - rust-lang#118533 (Suppress unhelpful diagnostics for unresolved top level attributes)
 - rust-lang#120293 (Deduplicate more sized errors on call exprs)
 - rust-lang#120295 (Remove `raw_os_nonzero` feature.)
 - rust-lang#120310 (adapt test for v0 symbol mangling)
 - rust-lang#120342 (Remove various `has_errors` or `err_count` uses)
 - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target")
 - rust-lang#120445 (Fix some `Arc` allocator leaks)
 - rust-lang#120475 (Improve error message when `cargo build` is used to build the compiler)
 - rust-lang#120476 (Remove some unnecessary check logic for lang items in HIR typeck)
 - rust-lang#120485 (add missing potential_query_instability for keys and values in hashmap)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6a1d34f into rust-lang:master Jan 30, 2024
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 30, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 30, 2024
@rust-timer
Unrolled build for rust-lang#120310
ccb77f0 
Rollup merge of rust-lang#120310 - krasimirgg:jan-v0-sym, r=Mark-Simulacrum

adapt test for v0 symbol mangling

No functional changes intended.

Adapts the test to also work under `new-symbol-mangling = true`.
@fmease
Copy link
Member

fmease commented Feb 3, 2024 •
edited
Loading

@Teapot4195

#120310 (review):

LGTM (here's a case where it would be convenient to have r+ perms)

#120579 (comment):

ah, how fun, wanted to be helpful and requeue all the timed out bors runs but...

Bors rights are restricted to privileged users only. Compiler team membership follows set procedures that are documented here: https://rustc-dev-guide.rust-lang.org/compiler-team.html#team-membership.

@Teapot4195
Copy link
Contributor

@Teapot4195

#120310 (review):

LGTM (here's a case where it would be convenient to have r+ perms)

#120579 (comment):

ah, how fun, wanted to be helpful and requeue all the timed out bors runs but...

Bors rights are restricted to privileged users only. Compiler team membership follows set procedures that are documented here: https://rustc-dev-guide.rust-lang.org/compiler-team.html#team-membership.

Yeah I figured as much, just a slight inconvenience but totally understandable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Teapot4195 Teapot4195 Teapot4195 approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.77.0
Development

Successfully merging this pull request may close these issues.
6 participants
@krasimirgg @rustbot @Mark-Simulacrum @bors @fmease @Teapot4195