Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mir-opt and custom target fixes #119619

Merged
merged 3 commits into from
Jan 9, 2024
Merged

mir-opt and custom target fixes #119619

merged 3 commits into from
Jan 9, 2024

Conversation

onur-ozkan
Copy link
Member

@onur-ozkan onur-ozkan commented Jan 5, 2024 •
edited
Loading

From #115642 (comment)

Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue.

I tested with the two commits and the errors of using nightly flag and custom target specs were not seen.
Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental.

Fixes #115642

@rustbot
Copy link
Collaborator

rustbot commented Jan 5, 2024

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jan 5, 2024
@onur-ozkan
Copy link
Member Author

@rustbot author (still testing)

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2024
@onur-ozkan
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 6, 2024
@onur-ozkan onur-ozkan marked this pull request as ready for review January 6, 2024 11:53
@onur-ozkan onur-ozkan mentioned this pull request Jan 6, 2024
Closed
@onur-ozkan
Copy link
Member Author

@rustbot author (will add another commit for handling #115642 (comment))

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 6, 2024
@onur-ozkan
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 7, 2024
@onur-ozkan
enable RUSTC_BOOTSTRAP on panic=abort mir-opt test
8aa7dd0 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
detect user-specified custom targets in compiletest
26c71cb 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@onur-ozkan
fix the incorrect target on stage1 ui-fulldeps tests
b888e2f 
Signed-off-by: onur-ozkan <work@onurozkan.dev>
@oli-obk
Copy link
Contributor

oli-obk commented Jan 8, 2024

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit b888e2f has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2024
@onur-ozkan onur-ozkan force-pushed the panic-abort-mir-opt branch 2 times, most recently from d0afa02 to b888e2f Compare January 8, 2024 16:48
@onur-ozkan
Copy link
Member Author

(accidentally pushed some changes on this branch, then reverted it)

@onur-ozkan
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Jan 8, 2024

📌 Commit b888e2f has been approved by oli-obk

It is now in the queue for this repository.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 8, 2024
@matthiaskrgr
Rollup merge of rust-lang#119619 - onur-ozkan:panic-abort-mir-opt, r=…
d39a8b0 
…oli-obk

mir-opt and custom target fixes

From rust-lang#115642 (comment)

> > Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue.

> I tested with the two commits and the errors of using nightly flag and custom target specs were not seen.
Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental.

Fixes rust-lang#115642
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 8, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@bors
Auto merge of rust-lang#119755 - matthiaskrgr:rollup-0tn7ybr, r=matth…
5891a01 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#117744 (Add -Zuse-sync-unwind)
 - rust-lang#118649 (Make inductive cycles in coherence ambiguous always)
 - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`)
 - rust-lang#119562 (Rename `pointer` field on `Pin`)
 - rust-lang#119619 (mir-opt and custom target fixes)
 - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026)
 - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.)
 - rust-lang#119734 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@bors
Auto merge of rust-lang#119760 - matthiaskrgr:rollup-ti2xpp7, r=matth…
387e7a5 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#117744 (Add -Zuse-sync-unwind)
 - rust-lang#118649 (Make inductive cycles in coherence ambiguous always)
 - rust-lang#118979 (Use `assert_unsafe_precondition` for `char::from_u32_unchecked`)
 - rust-lang#119619 (mir-opt and custom target fixes)
 - rust-lang#119632 (Fix broken build for ESP IDF due to rust-lang#119026)
 - rust-lang#119712 (Adding alignment to the cases to test for specific error messages.)
 - rust-lang#119734 (Miri subtree update)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 985b2ce into rust-lang:master Jan 9, 2024
22 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Jan 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jan 9, 2024
@rust-timer
Unrolled build for rust-lang#119619
e23f2f2 
Rollup merge of rust-lang#119619 - onur-ozkan:panic-abort-mir-opt, r=oli-obk

mir-opt and custom target fixes

From rust-lang#115642 (comment)

> > Could you please test the last two commits from https://github.com/onur-ozkan/rust/commits/panic-abort-mir-opt when you have the time? The first commit should resolve the error of using the nightly flag with a stable compiler, and the second one should resolve the custom target issue.

> I tested with the two commits and the errors of using nightly flag and custom target specs were not seen.
Testing was completed for the test suites like ui, run-pass-valgrind, coverage, mir-opt, codegen, assembly, incremental.

Fixes rust-lang#115642
@onur-ozkan
Copy link
Member Author

Each commit in this PR addresses an issue that also exists in the beta release.

@rustbot label +beta-accepted

cc @rust-lang/bootstrap

@rustbot rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Jan 9, 2024
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 9, 2024
@Mark-Simulacrum
Copy link
Member

(Adding beta-nominated. Please follow the beta backport process, or PRs will get missed: https://forge.rust-lang.org/release/backporting.html)

@cuviper cuviper mentioned this pull request Jan 11, 2024
Merged
@cuviper cuviper modified the milestones: 1.77.0, 1.76.0 Jan 11, 2024
@cuviper cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 11, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2024
@bors
Auto merge of rust-lang#119861 - cuviper:beta-next, r=cuviper
048e898 
[beta] backports

- mir-opt and custom target fixes rust-lang#119619
- Update LLVM submodule rust-lang#119802

r? ghost
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2024
@bors
Auto merge of rust-lang#119861 - cuviper:beta-next, r=cuviper
f732c37 
[beta] backports

- mir-opt and custom target fixes rust-lang#119619
- Update LLVM submodule rust-lang#119802

r? ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@oli-obk oli-obk

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.

Rust building and testing fails while bootstrapping it in poky
6 participants
@onur-ozkan @rustbot @oli-obk @bors @Mark-Simulacrum @cuviper