Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beta] Clippy (early) beta backport #119584

Closed
wants to merge 1 commit into from

Conversation

flip1995
Copy link
Member

@flip1995 flip1995 commented Jan 4, 2024

Early backport of

This is causing some major issues for Clippy beta-users. As those are the ones that help testing new lints early, we want to fix their issues ASAP.

r? @Mark-Simulacrum

cc @Manishearth

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2024

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against beta. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 4, 2024
@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jan 5, 2024

📌 Commit c8b56b4 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 5, 2024
@bors
Copy link
Contributor

bors commented Jan 6, 2024

⌛ Testing commit c8b56b4 with merge 8fe76ea...

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 6, 2024
…k-Simulacrum

[beta] Clippy (early) beta backport

Early backport of
- rust-lang/rust-clippy#11997

This is causing some major issues for Clippy beta-users. As those are the ones that help testing new lints early, we want to fix their issues ASAP.

r? `@Mark-Simulacrum`

cc `@Manishearth`
@bors
Copy link
Contributor

bors commented Jan 6, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 6, 2024
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@ehuss
Copy link
Contributor

ehuss commented Jan 6, 2024

There is an issue with the aarch64-apple runners (#119546). I might suggest holding off on beta PRs until that is resolved (or backporting if it isn't resolved in a few weeks).

@ehuss
Copy link
Contributor

ehuss commented Jan 6, 2024

Although it's not clear how urgent this PR is, perhaps backporting earlier might be warranted.

@Mark-Simulacrum
Copy link
Member

Rolled into #119719.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 7, 2024
…mulacrum

[beta] backport rollup

This PR backports:

- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo

And also:

- Bumps stage0 to released stable.

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 8, 2024
…mulacrum

[beta] backport rollup

This PR backports:

- rust-lang#119544: Fix: Properly set vendor in i686-win7-windows-msvc target
- rust-lang#118796: Exhaustiveness: Improve complexity on some wide matches
- rust-lang#119546: Temporarily disable M1 runners on GitHub Actions
- rust-lang#119584: [beta] Clippy (early) beta backport
- rust-lang#119559: [beta-1.76] Update cargo

And also:

- Bumps stage0 to released stable.

r? `@Mark-Simulacrum`
@flip1995 flip1995 deleted the clippy-beta-backport branch February 8, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants