Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NLL constraint generation and most of polonius fact generation #118216

Merged
merged 13 commits into from
Dec 1, 2023
Merged

Refactor NLL constraint generation and most of polonius fact generation #118216

merged 13 commits into from
Dec 1, 2023

Commits on Nov 26, 2023

  1. remove useless local variables

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    eca2789 View commit details
    Browse the repository at this point in the history

  2. extract polonius move fact generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    3de68e0 View commit details
    Browse the repository at this point in the history

  3. extract polonius universal regions fact generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    459a616 View commit details
    Browse the repository at this point in the history

  4. extract polonius loan invalidations fact generation 

    and move the polonius module to the borrowck root
    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    16a5da7 View commit details
    Browse the repository at this point in the history

  5. another trivial cleanup 

    fix a comment and move a variable where it's used
    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    4901083 View commit details
    Browse the repository at this point in the history

  6. extract polonius "constraint generation" 

    to help review, this duplicates the existing NLL + polonius constraint
generation component, before splitting them up to only do what they
individually need.
    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    9f14698 View commit details
    Browse the repository at this point in the history

  7. remove NLL liveness from polonius constraint generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f53412a View commit details
    Browse the repository at this point in the history

  8. simplify polonius constraint generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    bfd88b0 View commit details
    Browse the repository at this point in the history

  9. rename polonius constraint generation to what it actually does: emit … 

    …loan kills
    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    951901b View commit details
    Browse the repository at this point in the history

  10. small polish of loan invalidations fact generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    c976bc1 View commit details
    Browse the repository at this point in the history

  11. remove polonius fact generation from NLL constraint generation

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    626289a View commit details
    Browse the repository at this point in the history

  12. merge NLL "constraint generation" into liveness

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    96042bc View commit details
    Browse the repository at this point in the history

  13. move remaining legacy polonius fact generation out of NLL module

    @lqd
    lqd committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    f969af2 View commit details
    Browse the repository at this point in the history