Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline rustc_serialize #116468

Merged
merged 6 commits into from
Oct 9, 2023
Merged

Streamline rustc_serialize #116468

merged 6 commits into from
Oct 9, 2023

Commits on Oct 5, 2023

  1. rustc_serialize: Remove unneeded feature decls. 

    I.e. `maybe_uninit_slice` and `new_uninit`.

Also sort the remaining features and remove an ugly, low-value comment.
    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    3ee6747 View commit details
    Browse the repository at this point in the history

  2. Remove unused serialization support for LinkedList.

    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    f703475 View commit details
    Browse the repository at this point in the history

  3. rustc_serialize: merge collection_impls.rs into serialize.rs. 

    `serialize.rs` has the `Encodable`/`Decodable` impls for lots of basic
types, including `Vec`. `collection_impls` has it for lots of collection
types. The distinction isn't really meaningful, and it's simpler to have
them all in a single file.
    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5f69ca6 View commit details
    Browse the repository at this point in the history

  4. Use collect for decoding more collection types.

    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    2db1d59 View commit details
    Browse the repository at this point in the history

  5. Streamline some Encodable impls. 

    Making them consistent with similar impls.
    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1d71971 View commit details
    Browse the repository at this point in the history

  6. Use collect to decode Vec. 

    It's hyper-optimized, we don't need our own unsafe code here.

This requires getting rid of all the `Allocator` stuff, which isn't
needed anyway.
    @nnethercote
    nnethercote committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    ad8271d View commit details
    Browse the repository at this point in the history