Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use generator witness for implied bounds #115173

Closed
wants to merge 5 commits into from

Conversation

aliemjay
Copy link
Member

@aliemjay aliemjay commented Aug 24, 2023

... and also don't draw implied bounds from the output type of generators and closures. FnDef is still an exception so that we keep supporting (edit: reverted):

fn absurd<T>() -> Option<&'static T> { None }

TODO open issues for the bugs fixed here. In the mean time there is tests/ui/async-await/generator-wf-check.rs

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2023
@aliemjay
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Aug 24, 2023

⌛ Trying commit d06f509 with merge c998a0147310b58319f4172e953bf2a9c5c5c5fa...

@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Aug 24, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 24, 2023
@aliemjay
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Aug 24, 2023

⌛ Trying commit 7d78764 with merge 3ba53ac6e3a6cb265590cf8c832c06260d624b6e...

@bors
Copy link
Contributor

bors commented Aug 24, 2023

☀️ Try build successful - checks-actions
Build commit: 3ba53ac6e3a6cb265590cf8c832c06260d624b6e (3ba53ac6e3a6cb265590cf8c832c06260d624b6e)

@compiler-errors compiler-errors added needs-fcp This change is insta-stable, so needs a completed FCP to proceed. T-types Relevant to the types team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 24, 2023
@aliemjay
Copy link
Member Author

@craterbot check

@craterbot
Copy link
Collaborator

👌 Experiment pr-115173 created and queued.
🤖 Automatically detected try build 3ba53ac6e3a6cb265590cf8c832c06260d624b6e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 24, 2023
@craterbot
Copy link
Collaborator

🚧 Experiment pr-115173 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-115173 is completed!
📊 5 regressed and 3 fixed (354298 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Aug 26, 2023
@Dylan-DPC
Copy link
Member

@aliemjay any updates on this?

@Dylan-DPC
Copy link
Member

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

@Dylan-DPC Dylan-DPC closed this Feb 13, 2024
@Dylan-DPC Dylan-DPC added S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-fcp This change is insta-stable, so needs a completed FCP to proceed. S-inactive Status: Inactive and waiting on the author. This is often applied to closed PRs. T-types Relevant to the types team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants