Improve code readability by moving fmt args directly into the string #114822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-rustdoc-json
|
Some changes occurred in src/librustdoc/clean/types.rs cc @camelid |
notriddle
reviewed
Aug 14, 2023
|
Updated! |
|
@bors r+ |
bors
added
S-waiting-on-bors
klensy
reviewed
Aug 15, 2023
| @@ -933,7 +933,7 @@ impl Collector { | |||
| if !item_path.is_empty() { | |||
| item_path.push(' '); | |||
| } | |||
| format!("{} - {}(line {})", filename.prefer_local(), item_path, line) | |||
There was a problem hiding this comment.
There was some discussion that mixing few types of format parameters is harder to read: it need to track different places over code, instead sticking to one method. Or not?
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 15, 2023
…provement, r=notriddle
Improve code readability by moving fmt args directly into the string
There are some of occurrences where I also transformed `write!(f, "{}", x)` into `f.write_str(x.as_str())`.
r? `@notriddle`
This was referenced Aug 15, 2023
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 16, 2023
…provement, r=notriddle
Improve code readability by moving fmt args directly into the string
There are some of occurrences where I also transformed `write!(f, "{}", x)` into `f.write_str(x.as_str())`.
r? ``@notriddle``
GuillaumeGomez
force-pushed
the
code-readability-improvement
branch
from
9f21e6d
to
16b34bf
Compare
|
Fixed raw string. @bors r=notriddle |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 16, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#113115 (we are migrating to askama) - rust-lang#114784 (Improve `invalid_reference_casting` lint) - rust-lang#114822 (Improve code readability by moving fmt args directly into the string) - rust-lang#114878 (rustc book: make more pleasant to search) - rust-lang#114899 (Add missing Clone/Debug impls to SMIR Trait related tys) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some of occurrences where I also transformed
write!(f, "{}", x)intof.write_str(x.as_str()).r? @notriddle