Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fmt::Debug*: Fix comments for finish method. #114091

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

waywardmonkeys
Copy link
Contributor

In the code sample for the finish method on DebugList, DebugMap, and DebugSet, refer to finishing the list, map, or set, rather than struct as it did.

@rustbot
Copy link
Collaborator

rustbot commented Jul 26, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jul 26, 2023
In the code sample for the `finish` method on `DebugList`,
`DebugMap`, and `DebugSet`, refer to finishing the list, map, or
set, rather than struct as it did.
@GuillaumeGomez
Copy link
Member

Thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 27, 2023

📌 Commit 9f47ff8 has been approved by GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 27, 2023
…llaumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#114032 (typos)
 - rust-lang#114059 (rustdoc: fix cross-crate `impl Sized` & `impl ?Sized`)
 - rust-lang#114088 (Bump syn dependency)
 - rust-lang#114091 (docs: fmt::Debug*: Fix comments for finish method.)
 - rust-lang#114109 (Docs: Fix URL for `rmatches`)
 - rust-lang#114117 (Restore region uniquification in the new solver 🎉  )
 - rust-lang#114123 (Turns out opaque types can have hidden types registered during mir validation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ee54896 into rust-lang:master Jul 27, 2023
11 checks passed
@rustbot rustbot added this to the 1.73.0 milestone Jul 27, 2023
@waywardmonkeys waywardmonkeys deleted the doc-fmt-finish-comments branch August 21, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants