[perf] test MCP510 #113382

lqd · 2023-07-05T20:17:41Z

lqd · 2023-07-05T20:23:07Z

Let's see if the bootstrapping cfgs are correctly set up.

bors · 2023-07-05T20:23:16Z

⌛ Trying commit 793c8e6 with merge 4cb98396e9dc17fbe9b0da2b1bd35d9b05fff30c...

bors · 2023-07-05T21:59:24Z

☀️ Try build successful - checks-actions
Build commit: 4cb98396e9dc17fbe9b0da2b1bd35d9b05fff30c (4cb98396e9dc17fbe9b0da2b1bd35d9b05fff30c)

lqd · 2023-07-05T23:01:59Z

Let's see if the bootstrapping cfgs are correctly set up.

$  cargo +4cb98396e9dc17fbe9b0da2b1bd35d9b05fff30c build -q && readelf -p .comment ./target/debug/helloworld

String dump of section '.comment':
  [     0]  GCC: (Ubuntu 11.3.0-1ubuntu1~22.04.1) 11.3.0
  [    2d]  Linker: LLD 16.0.5

Looks like yes?

rust-timer · 2023-07-05T23:34:04Z

Finished benchmarking commit (4cb98396e9dc17fbe9b0da2b1bd35d9b05fff30c): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Warning ⚠: The following benchmark(s) failed to build:

rustc

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-34.1%	[-74.8%, -0.6%]	31
Improvements ✅ (secondary)	-32.7%	[-74.0%, -3.7%]	74
All ❌✅ (primary)	-34.1%	[-74.8%, -0.6%]	31

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	27.8%	[21.9%, 33.7%]	2
Regressions ❌ (secondary)	2.3%	[2.3%, 2.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	27.8%	[21.9%, 33.7%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-32.3%	[-65.9%, -1.4%]	28
Improvements ✅ (secondary)	-28.4%	[-64.8%, -3.3%]	73
All ❌✅ (primary)	-32.3%	[-65.9%, -1.4%]	28

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.6%	[0.6%, 2.4%]	20
Regressions ❌ (secondary)	0.5%	[0.4%, 1.1%]	61
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.1%]	2
All ❌✅ (primary)	1.6%	[0.6%, 2.4%]	20

Bootstrap: missing data

lqd · 2023-07-18T17:42:43Z

The data gathering is done so I'll close this for now, but may reopen to rerun crater on these new try artifacts.

rust-timer · 2024-08-13T16:40:33Z

Finished benchmarking commit (b3a6f31): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (secondary -3.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.2%	[-3.2%, -3.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 753.626s -> 753.401s (-0.03%)
Artifact size: 341.40 MiB -> 341.38 MiB (-0.01%)

lqd · 2024-08-13T17:24:04Z

@bors try @rust-timer queue

bors · 2024-08-13T17:25:13Z

⌛ Trying commit 9e62f88 with merge 044416e...

[perf] test MCP510 r? `@ghost`

bors · 2024-08-13T19:20:53Z

☀️ Try build successful - checks-actions
Build commit: 044416e (044416ed87e83cddf8446aebd3dd68bac309ab85)

rust-timer · 2024-08-13T20:36:29Z

Finished benchmarking commit (044416e): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.0%	[1.0%, 1.0%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -0.1%, secondary 2.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	2.3%	[2.1%, 2.5%]	2
Improvements ✅ (primary)	-2.7%	[-2.7%, -2.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.1%	[-2.7%, 2.5%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.976s -> 754.549s (0.21%)
Artifact size: 341.40 MiB -> 341.36 MiB (-0.01%)

TODO: This produces linker errors with ld.bfd, but works with ld.gold and ld.lld

lqd · 2024-09-06T09:04:38Z

@bors try @rust-timer queue

[perf] test MCP510 r? `@ghost`

bors · 2024-09-06T09:05:48Z

⌛ Trying commit 3fcb375 with merge 8303600...

rust-log-analyzer · 2024-09-06T09:32:39Z

The job x86_64-gnu-llvm-17 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

------
 > importing cache manifest from ghcr.io/rust-lang/rust-ci-cache:fb97a1d6377f6cf2227825318ca4bbde3889e0c420746f5a03ba46a07e9a862725c26a09b9fc49a0d129ebd75935d3f6cd19acf41cc4267a6846fd4aa574b12c:
------
##[endgroup]
Setting extra environment values for docker:  --env ENABLE_GCC_CODEGEN=1 --env GCC_EXEC_PREFIX=/usr/lib/gcc/
[CI_JOB_NAME=x86_64-gnu-llvm-17]
---
sccache: Starting the server...
##[group]Configure the build
configure: processing command line
configure: 
configure: build.configure-args := ['--build=x86_64-unknown-linux-gnu', '--llvm-root=/usr/lib/llvm-17', '--enable-llvm-link-shared', '--set', 'rust.randomize-layout=true', '--set', 'rust.thin-lto-import-instr-limit=10', '--set', 'change-id=99999999', '--enable-verbose-configure', '--enable-sccache', '--disable-manage-submodules', '--enable-locked-deps', '--enable-cargo-native-static', '--set', 'rust.codegen-units-std=1', '--set', 'dist.compression-profile=balanced', '--dist-compression-formats=xz', '--set', 'rust.lld=false', '--disable-dist-src', '--release-channel=nightly', '--enable-debug-assertions', '--enable-overflow-checks', '--enable-llvm-assertions', '--set', 'rust.verify-llvm-ir', '--set', 'rust.codegen-backends=llvm,cranelift,gcc', '--set', 'llvm.static-libstdcpp', '--enable-new-symbol-mangling']
configure: target.x86_64-unknown-linux-gnu.llvm-config := /usr/lib/llvm-17/bin/llvm-config
configure: llvm.link-shared     := True
configure: rust.randomize-layout := True
configure: rust.thin-lto-import-instr-limit := 10
---
failures:

---- [codegen] tests/codegen/default-hidden-visibility.rs#NO stdout ----

error in revision `NO`: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-17/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.NO/default-hidden-visibility.ll" "/checkout/tests/codegen/default-hidden-visibility.rs" "--check-prefix=CHECK" "--check-prefix" "NO" "--check-prefix" "NONMSVC" "--allow-unused-prefixes" "--dump-input-context" "100"
--- stderr -------------------------------
/checkout/tests/codegen/default-hidden-visibility.rs:31:8: error: NO: expected string not found in input
/checkout/tests/codegen/default-hidden-visibility.rs:31:8: error: NO: expected string not found in input
// NO: @{{.*}}default_hidden_visibility{{.*}}tested_symbol{{.*}} = constant
       ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.NO/default-hidden-visibility.ll:1:1: note: scanning from here
; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0'
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.NO/default-hidden-visibility.ll:6:1: note: possible intended match here
@_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1


Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.NO/default-hidden-visibility.ll


-dump-input=help explains the following input dump.
Input was:
<<<<<<
<<<<<<
            1: ; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0' 
check:31'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: source_filename = "default_hidden_visibility.1616fc4eed67881b-cgu.0" 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: target triple = "x86_64-unknown-linux-gnu" 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:31'0     ~
check:31'0     ~
            6: @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:31'1     ?                                                                                                                                         possible intended match
            7: @llvm.compiler.used = appending global [1 x ptr] [ptr @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE], section "llvm.metadata" 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:31'0     ~
check:31'0     ~
            9: !llvm.module.flags = !{!0, !1} 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           10: !llvm.ident = !{!2} 
check:31'0     ~~~~~~~~~~~~~~~~~~~~
check:31'0     ~
check:31'0     ~
           12: !0 = !{i32 8, !"PIC Level", i32 2} 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           13: !1 = !{i32 2, !"RtLibUseGOT", i32 1} 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           14: !2 = !{!"rustc version 1.83.0-nightly (65cd82c0b 2024-09-06)"} 
check:31'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
------------------------------------------


---- [codegen] tests/codegen/default-hidden-visibility.rs#DEFAULT stdout ----
---- [codegen] tests/codegen/default-hidden-visibility.rs#DEFAULT stdout ----

error in revision `DEFAULT`: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-17/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.DEFAULT/default-hidden-visibility.ll" "/checkout/tests/codegen/default-hidden-visibility.rs" "--check-prefix=CHECK" "--check-prefix" "DEFAULT" "--check-prefix" "NONMSVC" "--allow-unused-prefixes" "--dump-input-context" "100"
--- stderr -------------------------------
/checkout/tests/codegen/default-hidden-visibility.rs:29:13: error: DEFAULT: expected string not found in input
/checkout/tests/codegen/default-hidden-visibility.rs:29:13: error: DEFAULT: expected string not found in input
// DEFAULT: @{{.*}}default_hidden_visibility{{.*}}tested_symbol{{.*}} = constant
            ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.DEFAULT/default-hidden-visibility.ll:1:1: note: scanning from here
; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0'
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.DEFAULT/default-hidden-visibility.ll:6:1: note: possible intended match here
@_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1

Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.DEFAULT/default-hidden-visibility.ll
Check file: /checkout/tests/codegen/default-hidden-visibility.rs


-dump-input=help explains the following input dump.
Input was:
<<<<<<
<<<<<<
            1: ; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0' 
check:29'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: source_filename = "default_hidden_visibility.1616fc4eed67881b-cgu.0" 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: target triple = "x86_64-unknown-linux-gnu" 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:29'0     ~
check:29'0     ~
            6: @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:29'1     ?                                                                                                                                         possible intended match
            7: @llvm.compiler.used = appending global [1 x ptr] [ptr @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE], section "llvm.metadata" 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:29'0     ~
check:29'0     ~
            9: !llvm.module.flags = !{!0, !1} 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           10: !llvm.ident = !{!2} 
check:29'0     ~~~~~~~~~~~~~~~~~~~~
check:29'0     ~
check:29'0     ~
           12: !0 = !{i32 8, !"PIC Level", i32 2} 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           13: !1 = !{i32 2, !"RtLibUseGOT", i32 1} 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           14: !2 = !{!"rustc version 1.83.0-nightly (65cd82c0b 2024-09-06)"} 
check:29'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
------------------------------------------


---- [codegen] tests/codegen/default-hidden-visibility.rs#YES stdout ----
---- [codegen] tests/codegen/default-hidden-visibility.rs#YES stdout ----

error in revision `YES`: verification with 'FileCheck' failed
status: exit status: 1
command: "/usr/lib/llvm-17/bin/FileCheck" "--input-file" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.YES/default-hidden-visibility.ll" "/checkout/tests/codegen/default-hidden-visibility.rs" "--check-prefix=CHECK" "--check-prefix" "YES" "--check-prefix" "NONMSVC" "--allow-unused-prefixes" "--dump-input-context" "100"
--- stderr -------------------------------
/checkout/tests/codegen/default-hidden-visibility.rs:30:9: error: YES: expected string not found in input
/checkout/tests/codegen/default-hidden-visibility.rs:30:9: error: YES: expected string not found in input
// YES: @{{.*}}default_hidden_visibility{{.*}}tested_symbol{{.*}} = hidden constant
        ^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.YES/default-hidden-visibility.ll:1:1: note: scanning from here
; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0'
^
/checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.YES/default-hidden-visibility.ll:6:1: note: possible intended match here
@_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1


Input file: /checkout/obj/build/x86_64-unknown-linux-gnu/test/codegen/default-hidden-visibility.YES/default-hidden-visibility.ll


-dump-input=help explains the following input dump.
Input was:
<<<<<<
<<<<<<
            1: ; ModuleID = 'default_hidden_visibility.1616fc4eed67881b-cgu.0' 
check:30'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
            2: source_filename = "default_hidden_visibility.1616fc4eed67881b-cgu.0" 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            3: target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128" 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            4: target triple = "x86_64-unknown-linux-gnu" 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:30'0     ~
check:30'0     ~
            6: @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE = protected constant <{ [6 x i8] }> <{ [6 x i8] c"foobar" }>, align 1 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:30'1     ?                                                                                                                                         possible intended match
            7: @llvm.compiler.used = appending global [1 x ptr] [ptr @_ZN25default_hidden_visibility13tested_symbol17hcfcd04873622b2ceE], section "llvm.metadata" 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
check:30'0     ~
check:30'0     ~
            9: !llvm.module.flags = !{!0, !1} 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           10: !llvm.ident = !{!2} 
check:30'0     ~~~~~~~~~~~~~~~~~~~~
check:30'0     ~
check:30'0     ~
           12: !0 = !{i32 8, !"PIC Level", i32 2} 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           13: !1 = !{i32 2, !"RtLibUseGOT", i32 1} 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
           14: !2 = !{!"rustc version 1.83.0-nightly (65cd82c0b 2024-09-06)"} 
check:30'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
------------------------------------------

bors · 2024-09-06T10:57:40Z

☀️ Try build successful - checks-actions
Build commit: 8303600 (8303600399cc1a5d2d94b190f922eae5ea84b02d)

lqd · 2024-09-06T11:55:19Z

@rust-timer build 8303600

rust-timer · 2024-09-06T15:11:43Z

Finished benchmarking commit (8303600): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	5.3%	[5.3%, 5.3%]	1
Improvements ✅ (primary)	-2.3%	[-32.8%, -0.2%]	133
Improvements ✅ (secondary)	-4.7%	[-28.8%, -0.2%]	209
All ❌✅ (primary)	-2.3%	[-32.8%, -0.2%]	133

Max RSS (memory usage)

Results (primary -2.7%, secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-2.7%	[-7.2%, -0.6%]	159
Improvements ✅ (secondary)	-3.7%	[-7.1%, -0.8%]	203
All ❌✅ (primary)	-2.7%	[-7.2%, -0.6%]	159

Cycles

Results (primary -4.4%, secondary -7.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-4.4%	[-23.4%, -0.9%]	38
Improvements ✅ (secondary)	-7.5%	[-21.4%, -1.3%]	83
All ❌✅ (primary)	-4.4%	[-23.4%, -0.9%]	38

Binary size

Results (primary -0.3%, secondary -0.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-1.0%, -0.0%]	50
Improvements ✅ (secondary)	-0.6%	[-0.7%, -0.0%]	42
All ❌✅ (primary)	-0.3%	[-1.0%, -0.0%]	50

Bootstrap: 755.376s -> 754.704s (-0.09%)
Artifact size: 340.94 MiB -> 342.32 MiB (0.40%)

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 5, 2023

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 5, 2023

This comment was marked as duplicate.

Sign in to view

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 5, 2023

lqd closed this Jul 18, 2023

lqd reopened this Sep 12, 2023

lqd force-pushed the test-mcp510 branch from 793c8e6 to a9e047f Compare September 12, 2023 15:38

rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 12, 2023

This comment has been minimized.

Sign in to view

lqd force-pushed the test-mcp510 branch from a9e047f to 68e4f7d Compare September 12, 2023 17:25

lqd force-pushed the test-mcp510 branch from 68e4f7d to fb7cde3 Compare September 20, 2023 17:39

This comment was marked as resolved.

Sign in to view

lqd force-pushed the test-mcp510 branch from fb7cde3 to 3adfc22 Compare September 20, 2023 17:47

This comment was marked as outdated.

Sign in to view

lqd force-pushed the test-mcp510 branch from 3adfc22 to df25e9c Compare September 20, 2023 18:04

This comment was marked as resolved.

Sign in to view

lqd force-pushed the test-mcp510 branch from df25e9c to 03e476e Compare September 20, 2023 19:19

lqd closed this Sep 20, 2023

lqd reopened this Sep 21, 2023

lqd force-pushed the test-mcp510 branch from 03e476e to 5e67656 Compare September 21, 2023 18:31

rustbot removed the perf-regression Performance regression. label Aug 13, 2024

lqd force-pushed the test-mcp510 branch from 368aedc to 9e62f88 Compare August 13, 2024 17:23

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 13, 2024

Auto merge of rust-lang#113382 - lqd:test-mcp510, r=<try>

044416e

[perf] test MCP510 r? `@ghost`

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 13, 2024

lqd closed this Aug 13, 2024

lqd reopened this Aug 14, 2024

lqd closed this Aug 14, 2024

[WIP] Use protected visibility for all rust symbols

3fcb375

TODO: This produces linker errors with ld.bfd, but works with ld.gold and ld.lld

lqd reopened this Sep 6, 2024

lqd force-pushed the test-mcp510 branch from 9e62f88 to 3fcb375 Compare September 6, 2024 09:04

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 6, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 6, 2024

Auto merge of rust-lang#113382 - lqd:test-mcp510, r=<try>

8303600

[perf] test MCP510 r? `@ghost`

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Sep 6, 2024

lqd closed this Sep 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[perf] test MCP510 #113382

[perf] test MCP510 #113382

lqd commented Jul 5, 2023

lqd commented Jul 5, 2023

This comment has been minimized.

bors commented Jul 5, 2023

bors commented Jul 5, 2023

This comment was marked as duplicate.

This comment has been minimized.

lqd commented Jul 5, 2023 •

edited

Loading

rust-timer commented Jul 5, 2023

lqd commented Jul 18, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

rust-timer commented Aug 13, 2024

lqd commented Aug 13, 2024

This comment has been minimized.

bors commented Aug 13, 2024

bors commented Aug 13, 2024

This comment has been minimized.

rust-timer commented Aug 13, 2024

lqd commented Sep 6, 2024

This comment has been minimized.

bors commented Sep 6, 2024

rust-log-analyzer commented Sep 6, 2024

bors commented Sep 6, 2024

lqd commented Sep 6, 2024 •

edited

Loading

rust-timer commented Sep 6, 2024

[perf] test MCP510 #113382

[perf] test MCP510 #113382

Conversation

lqd commented Jul 5, 2023

lqd commented Jul 5, 2023

This comment has been minimized.

bors commented Jul 5, 2023

bors commented Jul 5, 2023

This comment was marked as duplicate.

This comment has been minimized.

lqd commented Jul 5, 2023 • edited Loading

rust-timer commented Jul 5, 2023

Overall result: ✅ improvements - no action needed

lqd commented Jul 18, 2023

This comment has been minimized.

This comment was marked as resolved.

This comment was marked as outdated.

This comment was marked as resolved.

rust-timer commented Aug 13, 2024

Overall result: no relevant changes - no action needed

lqd commented Aug 13, 2024

This comment has been minimized.

bors commented Aug 13, 2024

bors commented Aug 13, 2024

This comment has been minimized.

rust-timer commented Aug 13, 2024

Overall result: ❌ regressions - no action needed

lqd commented Sep 6, 2024

This comment has been minimized.

bors commented Sep 6, 2024

rust-log-analyzer commented Sep 6, 2024

bors commented Sep 6, 2024

lqd commented Sep 6, 2024 • edited Loading

rust-timer commented Sep 6, 2024

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

lqd commented Jul 5, 2023 •

edited

Loading

lqd commented Sep 6, 2024 •

edited

Loading