Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid &format in error message code #112933

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Avoid &format in error message code #112933

merged 1 commit into from
Jun 23, 2023
+7 −9

Conversation

TaKO8Ki
Copy link
Member

@TaKO8Ki TaKO8Ki commented Jun 22, 2023

follow-up of #111633

@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2023

r? @eholk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 22, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 22, 2023

rustc_macros::diagnostics was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@oli-obk
Copy link
Contributor

oli-obk commented Jun 22, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 22, 2023

📌 Commit c896062 has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 23, 2023
@matthiaskrgr
Rollup merge of rust-lang#112933 - TaKO8Ki:avoid-&format-in-error-mes…
818bc2d 
…sage-code, r=oli-obk

Avoid `&format` in error message code

follow-up of rust-lang#111633
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 23, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 23, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 23, 2023
@bors
Auto merge of rust-lang#112957 - matthiaskrgr:rollup-7ly0nv7, r=matth…
54d6738 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#111747 (Don't structurally resolve during method ambiguity in probe)
 - rust-lang#112704 (slice::from_raw_parts: mention no-wrap-around condition)
 - rust-lang#112927 (Fix indentation for where clause in rustdoc pages)
 - rust-lang#112933 (Avoid `&format` in error message code)
 - rust-lang#112935 (style-guide: Fix typo)
 - rust-lang#112941 (typo)
 - rust-lang#112942 (style-guide: Organizational and editing tweaks (no semantic changes))
 - rust-lang#112944 (style-guide: Add language disclaiming any effects on non-default Rust styles)
 - rust-lang#112948 (Avoid guessing unknown trait implementation in suggestions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 4e96aba into rust-lang:master Jun 23, 2023
11 checks passed
@rustbot rustbot added this to the 1.72.0 milestone Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eholk eholk

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@TaKO8Ki @rustbot @oli-obk @bors @eholk