Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private-in-public lints implementation #111801

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Private-in-public lints implementation #111801

merged 1 commit into from
Jun 12, 2023

Conversation

Bryanskiy
Copy link
Contributor

Next part of RFC #48054.

r? @petrochenkov

@Bryanskiy
Copy link
Contributor Author

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@clubby789 clubby789 removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 20, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryanskiy Bryanskiy force-pushed the lints1 branch 2 times, most recently from fd748ba to 99cc56d Compare May 25, 2023 11:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Bryanskiy
Copy link
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 25, 2023
@bors

This comment was marked as resolved.

Sign in to view
petrochenkov
petrochenkov reviewed May 29, 2023
View reviewed changes
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_lint_defs/src/builtin.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Show resolved Hide resolved
compiler/rustc_privacy/src/lib.rs Outdated Show resolved Hide resolved
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 29, 2023
@Bryanskiy Bryanskiy force-pushed the lints1 branch 2 times, most recently from 24e5d3a to 051c5bf Compare June 8, 2023 18:21
@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 9, 2023
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jun 11, 2023

☀️ Try build successful - checks-actions
Build commit: 36c03d72fa8b8bf825de72a5154565aa26707d18 (36c03d72fa8b8bf825de72a5154565aa26707d18)

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 11, 2023

☀️ Try build successful - checks-actions
Build commit: 36c03d72fa8b8bf825de72a5154565aa26707d18 (36c03d72fa8b8bf825de72a5154565aa26707d18)

@rust-timer

This comment has been minimized.

Sign in to view
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (36c03d72fa8b8bf825de72a5154565aa26707d18): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.2%, 0.2%] 5
Regressions ❌
(secondary)		 0.3% [0.2%, 0.4%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.2%, 0.2%] 5

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.7% [3.7%, 3.7%] 1
Regressions ❌
(secondary)		 2.0% [1.3%, 3.8%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) 3.7% [3.7%, 3.7%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.255s -> 647.39s (0.02%)

@rustbot rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 11, 2023
@petrochenkov
Copy link
Contributor

r=me after extending the comment in #111801 (comment) and squashing commits.

@petrochenkov
Copy link
Contributor

@bors r+ rollup=maybe

@bors
Copy link
Contributor

bors commented Jun 11, 2023

📌 Commit 6d46382 has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2023
@bors
Copy link
Contributor

bors commented Jun 11, 2023

⌛ Testing commit 6d46382 with merge 77dba22...

@bors
Copy link
Contributor

bors commented Jun 12, 2023

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing 77dba22 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2023
@bors bors merged commit 77dba22 into rust-lang:master Jun 12, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 12, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (77dba22): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.2% [0.1%, 0.2%] 3
Regressions ❌
(secondary)		 0.6% [0.2%, 1.1%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.2% [0.1%, 0.2%] 3

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 1.2% [1.2%, 1.3%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.6% [-2.6%, -2.6%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.784s -> 647.92s (-0.44%)

@pnkfelix
Copy link
Member

  • primary regressions were to stm32f4-0.14.0 check+opt incr, but by a really small amount (0.18%).
  • marking as triaged.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Jun 13, 2023
@petrochenkov petrochenkov mentioned this pull request Jun 15, 2023
Merged
petrochenkov added a commit to petrochenkov/rust that referenced this pull request Jun 15, 2023
@petrochenkov
privacy: Do not mark items reachable farther than their nominal visib…
95a24c6 
…ility

This commit reverts a change made in rust-lang#111425.
It was believed that this change was necessary for implementing type privacy lints, but rust-lang#111801 showed that it was not necessary.
Quite opposite, the revert fixes some issues.
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 29, 2023
@matthiaskrgr
Rollup merge of rust-lang#112670 - petrochenkov:typriv, r=eholk
42a495d 
privacy: Type privacy lints fixes and cleanups

See individual commits.
Follow up to rust-lang#111801.
thomcc pushed a commit to tcdi/postgrestd that referenced this pull request Aug 24, 2023
@matthiaskrgr
Rollup merge of #112670 - petrochenkov:typriv, r=eholk
a455c94 
privacy: Type privacy lints fixes and cleanups

See individual commits.
Follow up to rust-lang/rust#111801.
@Nadrieril Nadrieril mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
8 participants
@Bryanskiy @rust-log-analyzer @bors @petrochenkov @rust-timer @pnkfelix @clubby789 @rustbot