Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ICU4X to 1.2 #111104

Merged
merged 2 commits into from
May 4, 2023
Merged

Update ICU4X to 1.2 #111104

merged 2 commits into from
May 4, 2023

Conversation

Manishearth
Copy link
Member

Was released a couple weeks ago.

Also needed to make progress on #109302 (though this PR does not achieve that part just yet)

@Manishearth Manishearth requested a review from davidtwco May 2, 2023 17:48
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2023

These commits modify the Cargo.lock file. Random changes to Cargo.lock can be introduced when switching branches and rebasing PRs.
This was probably unintentional and should be reverted before this PR is merged.

If this was intentional then you can ignore this comment.

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @TaKO8Ki

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 2, 2023

📌 Commit 6382876 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 2, 2023
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111104 - Manishearth:icuup, r=compiler-errors
93acb8b 
Update ICU4X to 1.2

Was released a couple weeks ago.

Also needed to make progress on rust-lang#109302 (though this PR does not achieve that part just yet)
@Manishearth Manishearth mentioned this pull request May 3, 2023
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111104 - Manishearth:icuup, r=compiler-errors
9ce8348 
Update ICU4X to 1.2

Was released a couple weeks ago.

Also needed to make progress on rust-lang#109302 (though this PR does not achieve that part just yet)
@Manishearth Manishearth mentioned this pull request May 3, 2023
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request May 3, 2023
@Manishearth
Rollup merge of rust-lang#111104 - Manishearth:icuup, r=compiler-errors
8c53320 
Update ICU4X to 1.2

Was released a couple weeks ago.

Also needed to make progress on rust-lang#109302 (though this PR does not achieve that part just yet)
This was referenced May 3, 2023
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 4, 2023
@bors
Auto merge of rust-lang#111169 - Manishearth:rollup-55sfaad, r=Manish…
129195f 
…earth

Rollup of 10 pull requests

Successful merges:

 - rust-lang#97594 (Implement tuple<->array convertions via `From`)
 - rust-lang#105452 (Add cross-language LLVM CFI support to the Rust compiler)
 - rust-lang#105695 (Replace generic thread parker with explicit no-op parker)
 - rust-lang#110371 (rustdoc: restructure type search engine to pick-and-use IDs)
 - rust-lang#110928 (tests: Add tests for LoongArch64)
 - rust-lang#110970 (tidy: remove ENTRY_LIMIT maximum checking and set it to 900)
 - rust-lang#111104 (Update ICU4X to 1.2)
 - rust-lang#111127 (Constify slice flatten method)
 - rust-lang#111146 (rustc_middle: Fix `opt_item_ident` for non-local def ids)
 - rust-lang#111154 (Use builtin FFX isolation for Fuchsia test runner)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 8a0e4be into rust-lang:master May 4, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

@davidtwco davidtwco Awaiting requested review from davidtwco

Assignees

@compiler-errors compiler-errors

Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Manishearth @rustbot @compiler-errors @bors