Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate rustc_hir_analysis to session diagnostic [Part 4] #110325

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Migrate rustc_hir_analysis to session diagnostic [Part 4] #110325

merged 1 commit into from
Apr 25, 2023

Conversation

obeis
Copy link
Contributor

@obeis obeis commented Apr 14, 2023 •
edited
Loading

Part 4: Finishing check/mod.rs file

r? @compiler-errors

@rustbot
Copy link
Collaborator

rustbot commented Apr 14, 2023

r? @davidtwco

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 14, 2023
@rustbot rustbot assigned compiler-errors and unassigned davidtwco Apr 14, 2023
compiler-errors
compiler-errors reviewed Apr 19, 2023
View reviewed changes
compiler/rustc_hir_analysis/src/check/mod.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/errors.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/src/errors.rs Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Outdated Show resolved Hide resolved
compiler/rustc_hir_analysis/messages.ftl Show resolved Hide resolved
compiler/rustc_hir_analysis/src/check/mod.rs Outdated Show resolved Hide resolved
@compiler-errors
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 19, 2023
@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-4 branch from f2b469c to 3bc3aae Compare April 20, 2023 13:09
@obeis
Copy link
Contributor Author

obeis commented Apr 20, 2023

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 20, 2023
@bors

This comment was marked as resolved.

Sign in to view
@obeis
Migrate rustc_hir_analysis to session diagnostic
06ff310 
Part 4: Finishing `check/mod.rs` file
@obeis obeis force-pushed the hir-analysis-migrate-diagnostics-4 branch from 3bc3aae to 06ff310 Compare April 21, 2023 20:50
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 24, 2023

📌 Commit 06ff310 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
@matthiaskrgr
Rollup merge of rust-lang#110325 - obeis:hir-analysis-migrate-diagnos…
66e0836 
…tics-4, r=davidtwco

Migrate `rustc_hir_analysis` to session diagnostic [Part 4]

Part 4: Finishing `check/mod.rs` file

r? `@compiler-errors`
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 24, 2023
Closed
@bors
Copy link
Contributor

bors commented Apr 25, 2023

⌛ Testing commit 06ff310 with merge a7aa205...

@bors
Copy link
Contributor

bors commented Apr 25, 2023

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing a7aa205 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 25, 2023
@bors bors merged commit a7aa205 into rust-lang:master Apr 25, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 25, 2023
@bors bors mentioned this pull request Apr 25, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a7aa205): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)		 -2.0% [-2.0%, -2.0%] 1
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@obeis obeis deleted the hir-analysis-migrate-diagnostics-4 branch May 13, 2023 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

@davidtwco davidtwco davidtwco approved these changes

Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
6 participants
@obeis @rustbot @compiler-errors @bors @davidtwco @rust-timer