Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most ui-fulldeps tests to ui/ #109875

Merged
merged 2 commits into from
Apr 14, 2023
Merged

Move most ui-fulldeps tests to ui/ #109875

merged 2 commits into from
Apr 14, 2023

Commits on Apr 14, 2023

  1. Move most ui-fulldeps tests to ui 

    They pass fine. Only tests that required `extern crate rustc_*` or were
marked `ignore-stage1` have been keep in fulldeps.
    @jyn514
    jyn514 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    2ffb0de View commit details
    Browse the repository at this point in the history

  2. Fix tests on wasm 

    The `std` test straightforwardly can't work without file descriptors;
 rust-lang#99417 tracks moving it out of tests/ui.

`issue-13560.rs` requires the target to support dynamic linking.

`extern-mod-syntax` is interesting. The original test was added to check
if `extern mod` could be parsed correctly and used `extern mod std` and
an import:
rust-lang@138dc30#diff-73700e1e851b7a37bc92174635dab726124c82e5bfabbbc45b4a3c2e8e14fadd
At some point `std::json::Object` was moved out of std to an unstable
rustc-only `extras` crate, and rather than just changing the import it
got changed to use the unstable crate. When `extras` was removed, people
assumed the test was meant to also test rustc_private and changed it to
another unstable crate rather than using something in std.

This changes the test to remove the `rustc_private` import, to allow it
to work properly when cross-compiling.
    @jyn514
    jyn514 committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    88ee6e5 View commit details
    Browse the repository at this point in the history