Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove type ascription from parser and diagnostics #109128

Merged
merged 13 commits into from
May 2, 2023
Merged

Remove type ascription from parser and diagnostics #109128

merged 13 commits into from
May 2, 2023

Commits on May 1, 2023

  1. Rip it out 

    My type ascription
Oh rip it out
Ah
If you think we live too much then
You can sacrifice diagnostics
Don't mix your garbage
Into my syntax
So many weird hacks keep diagnostics alive
Yet I don't even step outside
So many bad diagnostics keep tyasc alive
Yet tyasc doesn't even bother to survive!
    @Noratrieb @chenyukang
    Noratrieb authored and chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    c63b6a4 View commit details
    Browse the repository at this point in the history

  2. Remove more diagnostics for ascription in resolve

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    9569a01 View commit details
    Browse the repository at this point in the history

  3. remove type_ascription_path_suggestions in parser

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f65b875 View commit details
    Browse the repository at this point in the history

  4. remove current_type_ascription from DiagnosticMetadata

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    10512b2 View commit details
    Browse the repository at this point in the history

  5. clean up debug code

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    1b08eac View commit details
    Browse the repository at this point in the history

  6. fix test cases

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f44ebf7 View commit details
    Browse the repository at this point in the history

  7. clean up Colon from clippy

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    102046d View commit details
    Browse the repository at this point in the history

  8. fix parser size

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    a4453c2 View commit details
    Browse the repository at this point in the history

  9. fix tests

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    f544899 View commit details
    Browse the repository at this point in the history

  10. fix doc test in mir_build for removing type ascription

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    7f98bef View commit details
    Browse the repository at this point in the history

  11. remove rustfmt testcase for type ascription

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    d2236b9 View commit details
    Browse the repository at this point in the history

  12. sync with master

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    0fe1ff2 View commit details
    Browse the repository at this point in the history

  13. soften the wording for removing type ascription

    @chenyukang
    chenyukang committed May 1, 2023
    Configuration menu
    Copy the full SHA
    5d1796a View commit details
    Browse the repository at this point in the history