Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Don't resolve link to field on different variant #107912

Merged
merged 1 commit into from
Feb 11, 2023
Merged

rustdoc: Don't resolve link to field on different variant #107912

merged 1 commit into from
Feb 11, 2023

Conversation

clubby789
Copy link
Contributor

Fix #107903

This also gives a more specific diagnostic when the enum has any fields

@rustbot
Copy link
Collaborator

rustbot commented Feb 11, 2023

r? @GuillaumeGomez

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 11, 2023
camelid
camelid reviewed Feb 11, 2023
View reviewed changes
Copy link
Member

@camelid camelid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this will cause new warnings to appear for paths that previously resolved incorrectly, right?

@clubby789
Copy link
Contributor Author

That's right - tested with the example from the linked issue

@GuillaumeGomez
Copy link
Member

Thanks for this improvement!

@bors r=camelid,GuillaumeGomez rollup

@bors
Copy link
Contributor

bors commented Feb 11, 2023

📌 Commit ef8de38 has been approved by camelid,GuillaumeGomez

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 11, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 11, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 11, 2023
@bors
Auto merge of rust-lang#107928 - matthiaskrgr:rollup-qnn380r, r=matth…
2b3f260 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#107657 (Add only modified subcommand for compiletest)
 - rust-lang#107864 (rustdoc: clean up `write!` calls with less stuttering)
 - rust-lang#107873 (Emit JSON output for the building of bootstrap itself)
 - rust-lang#107895 (remove redundant clones)
 - rust-lang#107897 (Reexported macros docs)
 - rust-lang#107909 (rustdoc: remove redundant `if s.is_empty()` from `find_testable_code`)
 - rust-lang#107912 (rustdoc: Don't resolve link to field on different variant)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c8614a7 into rust-lang:master Feb 11, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 11, 2023
@kadiwa4 kadiwa4 mentioned this pull request Apr 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.

Cargo doc spuriously links to random enum variant fields instead of marking links broken
5 participants
@clubby789 @rustbot @GuillaumeGomez @bors @camelid