Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add runners for vanilla LLVM 14 and 15 #107044

Merged
merged 1 commit into from
Jan 23, 2023
Merged

ci: add runners for vanilla LLVM 14 and 15 #107044

merged 1 commit into from
Jan 23, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 18, 2023 •
edited
Loading

As discussed in zulip #t-infra -- r? Mark-Simulacrum

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 18, 2023
cuviper
cuviper commented Jan 18, 2023
View reviewed changes
src/ci/docker/host-x86_64/x86_64-gnu-llvm-15/Dockerfile
@@ -0,0 +1,67 @@
FROM ubuntu:22.10
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is newer because 22.04 (LTS) doesn't have llvm-15. We should probably plan to keep rolling this forward until the next LTS.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jan 21, 2023

📌 Commit 318d77d has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 21, 2023
@Mark-Simulacrum
Copy link
Member

@bors rollup=iffy

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jan 22, 2023
@compiler-errors
Rollup merge of rust-lang#107044 - cuviper:more-llvm-ci, r=Mark-Simul…
b678a67 
…acrum

ci: add runners for vanilla LLVM 14 and 15

As discussed in [zulip #t-infra][1] -- r? Mark-Simulacrum

[1]: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/testing.20multiple.20llvm.20versions
@compiler-errors compiler-errors mentioned this pull request Jan 22, 2023
Closed
@bors
Copy link
Contributor

bors commented Jan 23, 2023

⌛ Testing commit 318d77d with merge ad48c10...

@bors
Copy link
Contributor

bors commented Jan 23, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing ad48c10 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 23, 2023
@bors bors merged commit ad48c10 into rust-lang:master Jan 23, 2023
@rustbot rustbot added this to the 1.69.0 milestone Jan 23, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ad48c10): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [3.5%, 3.5%] 1
Regressions ❌
(secondary)		 3.7% [1.4%, 7.5%] 4
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 3.5% [3.5%, 3.5%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

@cuviper cuviper mentioned this pull request Feb 9, 2023
Merged
@cuviper cuviper deleted the more-llvm-ci branch March 1, 2023 02:45
@cuviper cuviper mentioned this pull request Apr 12, 2023
Merged
cuviper added a commit to cuviper/rust that referenced this pull request Apr 16, 2023
@cuviper
ci: add a runner for vanilla LLVM 16
3303615 
Like rust-lang#107044, this will let us track compatibility with LLVM 16 going
forward, especially after we eventually upgrade our own to the next.

This also drops `tidy` here and in `x86_64-gnu-llvm-15`, syncing with
that change in rust-lang#106085.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2023
@bors
Auto merge of rust-lang#110242 - cuviper:vanilla-llvm-16, r=Mark-Simu…
5fe3528 
…lacrum

ci: add a runner for vanilla LLVM 16

Like rust-lang#107044, this will let us track compatibility with LLVM 16 going
forward, especially after we eventually upgrade our own to the next.

This also drops `tidy` here and in `x86_64-gnu-llvm-15`, syncing with
that change in rust-lang#106085.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
5 participants
@cuviper @Mark-Simulacrum @bors @rust-timer @rustbot