Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stabilize f16c_target_feature #106323

Merged
merged 1 commit into from
Jan 12, 2023
Merged

Stabilize f16c_target_feature #106323

merged 1 commit into from
Jan 12, 2023

Conversation

starkat99
Copy link
Contributor

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also #44839 tracking issue for target_feature

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @lcnr (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Dec 31, 2022
@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

This was referenced Dec 31, 2022
Merged
Closed
@lcnr
Copy link
Contributor

lcnr commented Jan 9, 2023

r? compiler

@rustbot rustbot assigned petrochenkov and unassigned lcnr Jan 9, 2023
@petrochenkov
Copy link
Contributor

Why is F16C still unstable?

I had the same question when seeing this PR, this x86 feature is sufficiently old.
If @Amanieu says nothing is blocking it, then let's stabilize.

Not sure whether an FCP is needed when stabilizing a minor target feature, probably not, so I'll only ping @rust-lang/compiler.

@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Jan 11, 2023

📌 Commit a29425c has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 12, 2023
@matthiaskrgr
Rollup merge of rust-lang#106323 - starkat99:stabilize-f16c_target_fe…
744ec5c 
…ature, r=petrochenkov

Stabilize f16c_target_feature

Resolves rust-lang/stdarch#1234

Library PR for stabilizing corresponding intrinsics: rust-lang/stdarch#1366

See also rust-lang#44839 tracking issue for target_feature
@matthiaskrgr matthiaskrgr mentioned this pull request Jan 12, 2023
Closed
@compiler-errors compiler-errors mentioned this pull request Jan 12, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 12, 2023
@bors
Auto merge of rust-lang#106760 - compiler-errors:rollup-0bogyco, r=co…
606c390 
…mpiler-errors

Rollup of 8 pull requests

Successful merges:

 - rust-lang#103236 (doc: rewrite doc for signed int::{carrying_add,borrowing_sub})
 - rust-lang#103800 (Stabilize `::{core,std}::pin::pin!`)
 - rust-lang#106097 (Migrate mir_build diagnostics 2 of 3)
 - rust-lang#106170 (Move autoderef to `rustc_hir_analysis`)
 - rust-lang#106323 (Stabilize f16c_target_feature)
 - rust-lang#106360 (Tweak E0277 `&`-removal suggestions)
 - rust-lang#106524 (Label `struct/enum constructor` instead of `fn item`, mention that it should be called on type mismatch)
 - rust-lang#106739 (Remove `<dyn AstConv<'tcx>>::fun(c, ...)` calls in favour of `c.astconv().fun(...)`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 244b90e into rust-lang:master Jan 12, 2023
@rustbot rustbot added this to the 1.68.0 milestone Jan 12, 2023
@pnkfelix
Copy link
Member

@wesleywiser pointed out to me that there is some precedent for getting lang team sign off or at least rough approval on the stabilization of target features, see e.g. #93745

I'm personally inclined to trust T-libs-api's judgement w.r.t. the specific stabilization of f16c, but I also want to keep T-lang design team or T-compiler aware of such changes in general, and give them the chance say that stabilizing even minor target features needs some kind of team sign off beyond just T-libs-api...

So, I am nominating this for both T-compiler and T-lang, just so that they each note the process that was followed here (namely, trusting the judgement of @Amanieu with their T-libs-api hat on), and get a chance to say that a different process should be followed either here or in other cases in the future.

(Having said all that, I don't see a need to revert this PR itself, not without input from at least one of the teams for which I nominated this for discussion.)

@rustbot label: I-lang-nominated I-compiler-nominated

@rustbot rustbot added I-compiler-nominated Nominated for discussion during a compiler team meeting. I-lang-nominated Nominated for discussion during a lang team meeting. labels Jan 13, 2023
@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2023

My understanding is that the stabilization of the intrinsics in stdarch are under T-libs-api (rust-lang/stdarch#1366, still in FCP). However the actual target feature for #[target_feature] and #[cfg(target_feature)] is under T-lang.

@calebzulawski calebzulawski mentioned this pull request Feb 6, 2023
Merged
@pnkfelix pnkfelix mentioned this pull request Feb 9, 2023
Open
@ehuss ehuss mentioned this pull request Mar 4, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#107711 - calebzulawski:movbe, r=pnkfelix
7f5bffa 
Stabilize movbe target feature

Almost all "old" x86 target features are stable.  As far as I can tell, these are the last two unstable features in the `x86-64-v2` or `x86-64-v3` microarchitecture levels, so I'm not sure if it was an oversight or if they're still unstable for a reason (see rust-lang#106323 for `f16c`).

Note that this only stabilizes the target features, and not the intrinsics.

cc `@Amanieu`

r? `@rust-lang/lang`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#107711 - calebzulawski:movbe, r=pnkfelix
0f3a0dc 
Stabilize movbe target feature

Almost all "old" x86 target features are stable.  As far as I can tell, these are the last two unstable features in the `x86-64-v2` or `x86-64-v3` microarchitecture levels, so I'm not sure if it was an oversight or if they're still unstable for a reason (see rust-lang#106323 for `f16c`).

Note that this only stabilizes the target features, and not the intrinsics.

cc ``@Amanieu``

r? ``@rust-lang/lang``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 10, 2023
@matthiaskrgr
Rollup merge of rust-lang#107711 - calebzulawski:movbe, r=pnkfelix
93316d7 
Stabilize movbe target feature

Almost all "old" x86 target features are stable.  As far as I can tell, these are the last two unstable features in the `x86-64-v2` or `x86-64-v3` microarchitecture levels, so I'm not sure if it was an oversight or if they're still unstable for a reason (see rust-lang#106323 for `f16c`).

Note that this only stabilizes the target features, and not the intrinsics.

cc ```@Amanieu```

r? ```@rust-lang/lang```
@apiraino
Copy link
Contributor

I assume team discussion nominations can be removed by now

@rustbot label -I-compiler-nominated -I-lang-nominated

@rustbot rustbot removed I-compiler-nominated Nominated for discussion during a compiler team meeting. I-lang-nominated Nominated for discussion during a lang team meeting. labels Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.

Why is F16C still unstable?
8 participants
@starkat99 @rustbot @lcnr @petrochenkov @bors @pnkfelix @Amanieu @apiraino