Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Introduce lowering_arena to avoid creating AST nodes on the fly" #105879

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Revert "Introduce lowering_arena to avoid creating AST nodes on the fly" #105879

merged 1 commit into from
Dec 19, 2022

Conversation

Noratrieb
Copy link
Member

This reverts commit d9a1faa (#101499).

This was originally part of #101345 which has now been closed as a different approach is taken now.

r? @oli-obk

cc @spastorino

@Noratrieb
Revert "Introduce lowering_arena to avoid creating AST nodes on the fly"
d59a2ac 
This reverts commit d9a1faa.

This was originally part of a larger PR that has now been closed as a
different approach is taken now.
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 18, 2022
@oli-obk
Copy link
Contributor

oli-obk commented Dec 18, 2022

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 18, 2022

📌 Commit d59a2ac has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 18, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Dec 18, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2022
@bors
Auto merge of rust-lang#105883 - matthiaskrgr:rollup-v5n53t1, r=matth…
a474ebb 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#105419 (Add tests for rust-lang#41731)
 - rust-lang#105447 (Add a test for rust-lang#103095)
 - rust-lang#105842 (print argument name in arg mismatch if possible)
 - rust-lang#105863 (Update browser-ui-test version to reduce GUI tests flakyness)
 - rust-lang#105867 (remove redundant fn params that were only "used" in recursion)
 - rust-lang#105869 (don't clone Copy types)
 - rust-lang#105873 (use &str / String literals instead of format!())
 - rust-lang#105879 (Revert "Introduce lowering_arena to avoid creating AST nodes on the fly")

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 87a4694 into rust-lang:master Dec 19, 2022
@rustbot rustbot added this to the 1.68.0 milestone Dec 19, 2022
@Noratrieb Noratrieb deleted the revert-hir-arena branch December 23, 2022 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Noratrieb @oli-obk @bors @rustbot