-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #104805
Rollup of 6 pull requests #104805
Commits on Nov 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for db1cdd4 - Browse repository at this point
Copy the full SHA db1cdd4View commit details -
resolve: Don't use constructor def ids in the map for field names
Also do some minor cleanup to insertion of those field names
Configuration menu - View commit details
-
Copy full SHA for 5fc359f - Browse repository at this point
Copy the full SHA 5fc359fView commit details
Commits on Nov 23, 2022
-
* Set aria-label attribute on search input * Put anchor text directly into the DOM and not in the CSS
Configuration menu - View commit details
-
Copy full SHA for aa73e29 - Browse repository at this point
Copy the full SHA aa73e29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a2b955 - Browse repository at this point
Copy the full SHA 9a2b955View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11a5386 - Browse repository at this point
Copy the full SHA 11a5386View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d4a5c7 - Browse repository at this point
Copy the full SHA 0d4a5c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20f3de5 - Browse repository at this point
Copy the full SHA 20f3de5View commit details -
Configuration menu - View commit details
-
Copy full SHA for f995583 - Browse repository at this point
Copy the full SHA f995583View commit details -
Add regression test for issue 99938
That issue was a dupe of 99852, but it's always better to have multiple regression tests rather than one.
Configuration menu - View commit details
-
Copy full SHA for 9abd785 - Browse repository at this point
Copy the full SHA 9abd785View commit details
Commits on Nov 24, 2022
-
Rollup merge of rust-lang#104716 - lcnr:selection-candidate, r=lcnr
move 2 candidates into builtin candidate having separate candidates for these isn't too helpful i think r? types
Configuration menu - View commit details
-
Copy full SHA for ace9924 - Browse repository at this point
Copy the full SHA ace9924View commit details -
Rollup merge of rust-lang#104742 - WaffleLapkin:forbidden-SUPER-deref…
…, r=compiler-errors Make `deref_into_dyn_supertrait` lint the impl and not the usage Proposed by `@compiler-errors` in rust-lang#89460 (comment) r? `@crlf0710`
Configuration menu - View commit details
-
Copy full SHA for b1aa7f5 - Browse repository at this point
Copy the full SHA b1aa7f5View commit details -
Rollup merge of rust-lang#104747 - petrochenkov:ctorfields, r=cjgillot
resolve: Don't use constructor def ids in the map for field names Also do some minor cleanup to insertion of those field names. Addresses a FIXME left in rust-lang#103578.
Configuration menu - View commit details
-
Copy full SHA for ab75479 - Browse repository at this point
Copy the full SHA ab75479View commit details -
Rollup merge of rust-lang#104771 - est31:if_let_chain_broken_mir_test…
…, r=davidtwco Add regression test for issue rust-lang#99938 That issue was a dupe of rust-lang#99852, and it got fixed since, but it's always better to have multiple regression tests rather than one. closes rust-lang#99938
Configuration menu - View commit details
-
Copy full SHA for 2681fa9 - Browse repository at this point
Copy the full SHA 2681fa9View commit details -
Rollup merge of rust-lang#104772 - GuillaumeGomez:small-accessibility…
…-improvement, r=notriddle Small accessibility improvements From this [reddit post](https://www.reddit.com/r/rust/comments/z1gyz7/accessible_documentation/), I started to check a bit how to improve accessibility and how we could add test for it. So these two fixes come from the use of the [pa11y tool](https://github.com/pa11y/pa11y). To make it work, I had to update its puppeteer version to the last one but otherwise it seems to be quite nice. I didn't fix all the errors it reported because they were about colors. To get the same result as mine, you can use this config: ```json { "ignore": [ "WCAG2AA.Principle1.Guideline1_4.1_4_3.G18.Fail", "WCAG2AA.Principle3.Guideline3_2.3_2_2.H32.2" ] } ``` I think trying to improve accessibility is something we should definitely aim for. I'll try to integrate a tool to enforce this check (very likely `pa11y`) directly into the CI. cc `@jsha` r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for ca5e9ad - Browse repository at this point
Copy the full SHA ca5e9adView commit details -
Rollup merge of rust-lang#104774 - vojtechkral:doc-str-empty-split-wh…
…itespace, r=thomcc Document split{_ascii,}_whitespace() for empty strings doc change only
Configuration menu - View commit details
-
Copy full SHA for 294441e - Browse repository at this point
Copy the full SHA 294441eView commit details