Migrate no result page link color to CSS variables #104250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @Folyd, @jsha A change occurred in the Ayu theme. cc @Cldfire |
notriddle
reviewed
Nov 11, 2022
| @@ -34,6 +34,7 @@ | |||
| --sidebar-current-link-background-color: #444; | |||
| --search-result-link-focus-background-color: #616161; | |||
| --search-result-border-color: #aaa3; | |||
| --search-failed-link-color: #0089ff; | |||
There was a problem hiding this comment.
I see that, in this dark theme, the search failed link color is different from the ordinary link color, but in other themes, it's the same.
Is there a reason why they can't be the same color? It seems perfectly readable that way.
There was a problem hiding this comment.
I didn't notice. Then it makes this migration even simpler. I'll remove this variable and simply use the default color instead.
|
Done! Thanks again for the idea @notriddle ! |
|
☔ The latest upstream changes (presumably #104289) made this pull request unmergeable. Please resolve the merge conflicts. |
GuillaumeGomez
force-pushed
the
migrate-not-found-link-color
branch
from
620f79d
to
ee73812
Compare
|
Fixed merge conflict. |
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Nov 12, 2022
…ink-color, r=notriddle Migrate no result page link color to CSS variables r? `@notriddle`
This was referenced Nov 12, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 12, 2022
…llaumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#104110 (prevent uninitialized access in black_box for zero-sized-types) - rust-lang#104117 (Mark `trait_upcasting` feature no longer incomplete.) - rust-lang#104144 (Suggest removing unnecessary `.` to use a floating point literal) - rust-lang#104250 (Migrate no result page link color to CSS variables) - rust-lang#104261 (More accurately report error when formal and expected signature types differ) - rust-lang#104263 (Add a reference to ilog2 in leading_zeros integer docs) - rust-lang#104308 (Remove the old `ValidAlign` name) - rust-lang#104319 (Fix non clickable source link) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @notriddle