Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More panic info on failure of Windows rand #101456

Closed
wants to merge 1 commit into from
Closed

More panic info on failure of Windows rand #101456

wants to merge 1 commit into from

Conversation

ChrisDenton
Copy link
Member

Add the error messages of both BCryptGenRandom and RtlGenRandom in the (unlikely) event they both fail. Ideally I'd love to print diagnostic information if only BCryptGenRandom fails but that's not really possible here.

Also use an isize for the algorithm handle instead of a pointer. This matches the windows_sys crate and I think it doesn't make sense to pretend they're pointers when we don't (and won't) use them as such. But I can undo that change if it's a bridge too far.

r? @thomcc

@ChrisDenton
More panic info on failure of Windows rand
884f945 
Add the error messages of both `BCryptGenRandom` and `RtlGenRandom` in the (unlikely) event they both fail.

Also use an `isize` for the algorithm handle instead of a pointer. This matches the windows-sys crate.
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 5, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 5, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2022
@thomcc
Copy link
Member

thomcc commented Sep 6, 2022

I think it doesn't make sense to pretend they're pointers when we don't (and won't) use them as such. But I can undo that change if it's a bridge too far.

I think windows-sys goes way too far with is (since it uses isize even if the API sometimes returns pointers), but for this I don't mind. I will admit this is more verbose than I'd like to be, but it has been quite a pain and its not like panic strings are stable.

@bors r+

@bors
Copy link
Contributor

bors commented Sep 6, 2022

📌 Commit 884f945 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 6, 2022
@ChrisDenton
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 6, 2022
@ChrisDenton
Copy link
Member Author

I'm closing this and replacing with a PR that fixes a problem on WINE.

@ChrisDenton ChrisDenton closed this Sep 6, 2022
@ChrisDenton ChrisDenton mentioned this pull request Sep 6, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Sep 7, 2022
@Dylan-DPC
Rollup merge of rust-lang#101476 - ChrisDenton:BCryptRandom-fix, r=th…
5a89c6c 
…omcc

Open a BCrypt algorithm handle

Fixes rust-lang#101474, supplants rust-lang#101456.

Replaces use of a pseduo handle with manually opening a algorithm handle.

Most interesting thing here is the atomics.

r? `@thomcc`
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 7, 2022
@bors
Auto merge of rust-lang#101476 - ChrisDenton:BCryptRandom-fix, r=thomcc
9682b5d 
Open a BCrypt algorithm handle

Fixes rust-lang#101474, supplants rust-lang#101456.

Replaces use of a pseduo handle with manually opening a algorithm handle.

Most interesting thing here is the atomics.

r? `@thomcc`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ChrisDenton @rustbot @thomcc @bors @rust-highfive