Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SessionDiagnostic::into_diagnostic to take Handler instead of ParseSess #101434

Merged
merged 7 commits into from
Sep 6, 2022
Merged

Update SessionDiagnostic::into_diagnostic to take Handler instead of ParseSess #101434

merged 7 commits into from
Sep 6, 2022

Commits on Sep 5, 2022

  1. UPDATE - into_diagnostic to take a Handler instead of a ParseSess 

    Suggested by the team in this Zulip Topic https://rust-lang.zulipchat.com/#narrow/stream/336883-i18n/topic/.23100717.20SessionDiagnostic.20on.20Handler

Handler already has almost all the capabilities of ParseSess when it comes to diagnostic emission, in this migration we only needed to add the ability to access source_map from the emitter in order to get a Snippet and the start_point. Not sure if this is the best way to address this gap
    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    321e60b View commit details
    Browse the repository at this point in the history

  2. UPDATE - avoid exposing source_map methods from Handler

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    1524b59 View commit details
    Browse the repository at this point in the history

  3. FIX - broken translatable diagnostics tests

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    72f766a View commit details
    Browse the repository at this point in the history

  4. [Gardening] UPDATE - tidy fixes

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    d14b3af View commit details
    Browse the repository at this point in the history

  5. FIX - broken translatable diagnostics tests

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    31e9f40 View commit details
    Browse the repository at this point in the history

  6. UPDATE - accept start_point and snippet instead of SourceMap

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    dd5850b View commit details
    Browse the repository at this point in the history

  7. [Gardening] UPDATE - use let chain to unwrap snippet and evaluate flag

    @JhonnyBillM
    JhonnyBillM committed Sep 5, 2022
    Configuration menu
    Copy the full SHA
    46ba27d View commit details
    Browse the repository at this point in the history