Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net adding set_fib call to set FIB route on FreeBSD. #101213

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

net adding set_fib call to set FIB route on FreeBSD. #101213

wants to merge 1 commit into from
+50 −0

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Aug 30, 2022 •
edited by Dylan-DPC
Loading

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Aug 30, 2022
@rust-highfive
Copy link
Collaborator

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@devnexen devnexen marked this pull request as ready for review August 31, 2022 02:21
@joshtriplett
Copy link
Member

Could you please provide some more detailed documentation than "route FIB table id"? What is this, what effect does it have, why might people want to set it?

@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2022
@workingjubilee workingjubilee added the O-freebsd Operating system: FreeBSD label Feb 26, 2023
@ChrisDenton
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

Some changes occurred in src/tools/cargo

cc @ehuss

@devnexen
Copy link
Contributor Author

Various documentations had been updated.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Apr 16, 2023

☔ The latest upstream changes (presumably #109133) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 16, 2023
@bors
Copy link
Contributor

bors commented Jun 27, 2023

☔ The latest upstream changes (presumably #113083) made this pull request unmergeable. Please resolve the merge conflicts.

@workingjubilee workingjubilee added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jul 26, 2023
@workingjubilee
Copy link
Member

Is this call only available on FreeBSD or is an equivalent available on other OS?

@devnexen
Copy link
Contributor Author

good question ... sort of. The Linux's SO_MARK or the OpenBSD's SO_RTABLE are the closest I can think of.

@workingjubilee
Copy link
Member

If it isn't something we can clearly generalize across all so-called "Unix" OS with maybe 1 or 2 exceptions I would rather not add it via this path, then.

@workingjubilee
Copy link
Member

workingjubilee commented Jul 31, 2023 •
edited
Loading

Please open an ACP which discusses the options here re: this proposed new function call and also options for exposing it on other OS than FreeBSD (or not exposing it at all!). Basically the question is more or less "should this be available via some path like std::os::unix orrr should it be available via std::os::freebsd?"

@workingjubilee
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2023
@devnexen devnexen mentioned this pull request Jul 31, 2023
Open
@workingjubilee workingjubilee added S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 1, 2023
@bors
Copy link
Contributor

bors commented Jan 13, 2024

☔ The latest upstream changes (presumably #117285) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 13, 2024
@rustbot rustbot added the O-unix Operating system: Unix-like label Jan 13, 2024
@Dylan-DPC Dylan-DPC removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@workingjubilee workingjubilee

Labels
O-freebsd Operating system: FreeBSD O-unix Operating system: Unix-like S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@devnexen @rust-highfive @rust-log-analyzer @joshtriplett @ChrisDenton @rustbot @bors @workingjubilee @JohnCSimon @Dylan-DPC