Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 #100814

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 #100814

merged 1 commit into from
Sep 2, 2022

Conversation

gabrielBusta
Copy link
Contributor

@rustbot label +A-translation

r? rust-lang/diagnostics
cc #100717

@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 20, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 20, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
davidtwco
davidtwco reviewed Aug 23, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start, left a comment or two

compiler/rustc_error_messages/locales/en-US/trait_selection.ftl Outdated Show resolved Hide resolved
compiler/rustc_trait_selection/src/lib.rs Outdated Show resolved Hide resolved
@davidtwco
Copy link
Member

r? @davidtwco

@davidtwco davidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@bors

This comment was marked as resolved.

Sign in to view
@davidtwco
Copy link
Member

We have a no merge policy, do you think you could remove those merge commits? :)

@gabrielBusta gabrielBusta force-pushed the port_trait_selection_diagnostics branch from 2fbc967 to 1b81e3a Compare August 26, 2022 18:09
@gabrielBusta gabrielBusta changed the title Porting rustc_trait_selection diagnostics Porting 'compiler/rustc_trait_selection' to translatable diagnostics - Part 1 Aug 26, 2022
@gabrielBusta gabrielBusta marked this pull request as ready for review August 26, 2022 18:10
@rustbot
Copy link
Collaborator

rustbot commented Aug 26, 2022

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@gabrielBusta gabrielBusta force-pushed the port_trait_selection_diagnostics branch from 1b81e3a to 18feed3 Compare August 26, 2022 18:56
@gabrielBusta gabrielBusta force-pushed the port_trait_selection_diagnostics branch 2 times, most recently from 1d24c51 to 013994a Compare August 30, 2022 23:08
@gabrielBusta gabrielBusta force-pushed the port_trait_selection_diagnostics branch 2 times, most recently from 413d176 to 06a2d5b Compare August 31, 2022 20:57
@bors

This comment was marked as resolved.

Sign in to view
davidtwco
davidtwco approved these changes Sep 1, 2022
View reviewed changes
Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after rebase

@gabrielBusta gabrielBusta force-pushed the port_trait_selection_diagnostics branch from 06a2d5b to 8e82200 Compare September 1, 2022 17:55
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 2, 2022

📌 Commit 8e82200 has been approved by davidtwco

It is now in the queue for this repository.