Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try and simplify some things in the query system #100436

Merged
merged 4 commits into from
Aug 25, 2022
Merged

try and simplify some things in the query system #100436

merged 4 commits into from
Aug 25, 2022

Commits on Aug 24, 2022

  1. Remove $tcx metavariable from rustc_query_append 

    It's not actually necessary and it makes the code harder to read.
    @jyn514
    jyn514 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    b537619 View commit details
    Browse the repository at this point in the history

  2. Get rid of some usages of query_keys 

    Rustdoc documents these with the name of the type alias instead of normalizing them to the underlying type.
Use associated types instead so that the generated docs for nightly-rustc are easier to read.
    @jyn514
    jyn514 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    1de08b1 View commit details
    Browse the repository at this point in the history

  3. Move most of make_query into a generic function, away from the macro 

    This should both make the code easier to read and also greatly reduce the amount of codegen
the compiler has to do, since it only needs to monomorphize `create_query_frame` for each
new key and not for each query.
    @jyn514
    jyn514 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    0bedd35 View commit details
    Browse the repository at this point in the history

  4. get rid of another unnecessary lifetime macro argument

    @jyn514
    jyn514 committed Aug 24, 2022
    Configuration menu
    Copy the full SHA
    e188868 View commit details
    Browse the repository at this point in the history