Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shrink AST items #100363

Closed
wants to merge 14 commits into from
Closed

Shrink AST items #100363

wants to merge 14 commits into from

Commits on Aug 10, 2022

  1. Avoid repeating qualifiers on static_assert_size calls. 

    Some of these don't need a `use` statement because there is already a
`#[macro_use] extern crate rustc_data_structures` item in the crate.
    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    574ba83 View commit details
    Browse the repository at this point in the history

  2. Add a couple more AST node size assertions.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    0658e8c View commit details
    Browse the repository at this point in the history

  3. Simplify rustc_hir::intravisit::Visitor::visit_variant_data. 

    It has four arguments that are never used. This avoids lots of argument
passing in functions that feed into `visit_variant_data`.
    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    8ec3d0d View commit details
    Browse the repository at this point in the history

  4. Simplify rustc_ast::visit::Visitor::visit_enum_def. 

    It's passed three arguments that are never used.
    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    694dbc8 View commit details
    Browse the repository at this point in the history

  5. Box the Generics in ItemKind::{Enum,Struct,Union,TraitAlias}.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    07a2eb1 View commit details
    Browse the repository at this point in the history

  6. Box the UseTree in ItemKind::UseTree.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    5c7b4e7 View commit details
    Browse the repository at this point in the history

  7. Box the ForeignMod in ItemKind::ForeignMod.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    d665e9c View commit details
    Browse the repository at this point in the history

  8. Box the MacCall in various types.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    cb6230e View commit details
    Browse the repository at this point in the history

  9. Box the ForeignMod in ItemKind::ForeignMod.

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e71c375 View commit details
    Browse the repository at this point in the history

  10. XXX: redoing Enum

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    19db44f View commit details
    Browse the repository at this point in the history

  11. XXX: redoing Struct/Union/TraitAlias

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    e71f89d View commit details
    Browse the repository at this point in the history

  12. XXX: Const/Constness

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    300d74d View commit details
    Browse the repository at this point in the history

  13. XXX: Static

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    c0a3752 View commit details
    Browse the repository at this point in the history

  14. XXX: various fixes for CI failures

    @nnethercote
    nnethercote committed Aug 10, 2022
    Configuration menu
    Copy the full SHA
    0e9ea62 View commit details
    Browse the repository at this point in the history