Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NLL] Loss of suggestion to introduce a named lifetime parameter #96157

Closed
marmeladema opened this issue Apr 17, 2022 · 1 comment · Fixed by #96409
Closed

[NLL] Loss of suggestion to introduce a named lifetime parameter #96157

marmeladema opened this issue Apr 17, 2022 · 1 comment · Fixed by #96409
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non Lexical Lifetimes (NLL) NLL-diagnostics Working torwads the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@marmeladema
Copy link
Contributor

In the src/test/ui/self/arbitrary_self_types_pin_lifetime_mismatch.base.rs test, we give the suggestion to consider introducing a named lifetime parameter and update trait if needed under migrate mode. Under NLL, the error message is imo clearer but we lose that suggestion.
@marmeladema marmeladema added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 17, 2022
@marmeladema marmeladema mentioned this issue Apr 17, 2022
Merged
@marmeladema
Copy link
Contributor Author

@rustbot label +A-NLL +NLL-diagnostics

@rustbot rustbot added A-NLL Area: Non Lexical Lifetimes (NLL) NLL-diagnostics Working torwads the "diagnostic parity" goal labels Apr 19, 2022
@marmeladema marmeladema mentioned this issue Apr 25, 2022
Merged
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Apr 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#96409 - marmeladema:fix-nll-introduce-named…
021a4ff 
…-lifetime-suggestion, r=jackh726

Recover suggestions to introduce named lifetime under NLL

Fixes rust-lang#96157

r? `@jackh726`

Built on top of rust-lang#96385 so only the second commit is relevant
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this issue Apr 28, 2022
@Dylan-DPC
Rollup merge of rust-lang#96409 - marmeladema:fix-nll-introduce-named…
c9fb0b4 
…-lifetime-suggestion, r=jackh726

Recover suggestions to introduce named lifetime under NLL

Fixes rust-lang#96157

r? ``@jackh726``

Built on top of rust-lang#96385 so only the second commit is relevant
@bors bors closed this as completed in cbfbc3b Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-NLL Area: Non Lexical Lifetimes (NLL) NLL-diagnostics Working torwads the "diagnostic parity" goal T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Recover suggestions to introduce named lifetime under NLL marmeladema/rust
2 participants
@marmeladema @rustbot