Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rustdoc-gui test for #89867 #90015

Closed
GuillaumeGomez opened this issue Oct 18, 2021 · 0 comments · Fixed by #90097
Closed

Add rustdoc-gui test for #89867 #90015

GuillaumeGomez opened this issue Oct 18, 2021 · 0 comments · Fixed by #90097
Assignees
@GuillaumeGomez
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

To ensure that the items are not duplicated in the sidebar, #89867 added a test for the JS content, but having a rustdoc-gui test would make it 100% sure that we're not missing anything.
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Oct 18, 2021
@GuillaumeGomez GuillaumeGomez self-assigned this Oct 18, 2021
@GuillaumeGomez GuillaumeGomez mentioned this issue Oct 20, 2021
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Oct 20, 2021
@matthiaskrgr
Rollup merge of rust-lang#90097 - GuillaumeGomez:duplicated-sidebar-e…
6016109 
…ntry-reexported-macro, r=notriddle

Add test for duplicated sidebar entries for reexported macro

Fixes rust-lang#90015.

r? `@notriddle`
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue Oct 20, 2021
@GuillaumeGomez
Rollup merge of rust-lang#90097 - GuillaumeGomez:duplicated-sidebar-e…
d5cd6e0 
…ntry-reexported-macro, r=notriddle

Add test for duplicated sidebar entries for reexported macro

Fixes rust-lang#90015.

r? ``@notriddle``
JohnTitor added a commit to JohnTitor/rust that referenced this issue Oct 21, 2021
@JohnTitor
Rollup merge of rust-lang#90097 - GuillaumeGomez:duplicated-sidebar-e…
248d914 
…ntry-reexported-macro, r=notriddle

Add test for duplicated sidebar entries for reexported macro

Fixes rust-lang#90015.

r? ```@notriddle```
@bors bors closed this as completed in 759a8ae Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add test for duplicated sidebar entries for reexported macro GuillaumeGomez/rust
1 participant
@GuillaumeGomez