Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICE with Unicode character following if in if conditional without condition #68091

Closed
KamilaBorowska opened this issue Jan 10, 2020 · 0 comments · Fixed by #68084
Closed

ICE with Unicode character following if in if conditional without condition #68091

KamilaBorowska opened this issue Jan 10, 2020 · 0 comments · Fixed by #68084
Assignees
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. C-bug Category: This is a bug. D-unicode-unaware Diagnostics: Diagnostics that are unaware of unicode and trigger codepoint boundary assertions glacier ICE tracked in rust-lang/glacier. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@KamilaBorowska
Copy link
Contributor

KamilaBorowska commented Jan 10, 2020

Inspired by #68000. Nobody will write code like this ever, but it's still an ICE. This regression was introduced in Rust 1.25, this worked in Rust 1.24.

macro_rules! x {
    ($($c:tt)*) => {
        $($c)ö* {}
    };
}

fn main() {
    x!(if);
}

Stacktrace on playground:

   Compiling playground v0.0.1 (/playground)
thread 'rustc' panicked at 'assertion failed: bpos.to_u32() >= mbc.pos.to_u32() + mbc.bytes as u32', src/libsyntax_pos/source_map.rs:836:17
stack backtrace:
   0: backtrace::backtrace::libunwind::trace
             at /cargo/registry/src/github.51.al-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1: backtrace::backtrace::trace_unsynchronized
             at /cargo/registry/src/github.51.al-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2: std::sys_common::backtrace::_print_fmt
             at src/libstd/sys_common/backtrace.rs:77
   3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
             at src/libstd/sys_common/backtrace.rs:59
   4: core::fmt::write
             at src/libcore/fmt/mod.rs:1057
   5: std::io::Write::write_fmt
             at src/libstd/io/mod.rs:1426
   6: std::sys_common::backtrace::_print
             at src/libstd/sys_common/backtrace.rs:62
   7: std::sys_common::backtrace::print
             at src/libstd/sys_common/backtrace.rs:49
   8: std::panicking::default_hook::{{closure}}
             at src/libstd/panicking.rs:195
   9: std::panicking::default_hook
             at src/libstd/panicking.rs:215
  10: rustc_driver::report_ice
  11: std::panicking::rust_panic_with_hook
             at src/libstd/panicking.rs:476
  12: std::panicking::begin_panic
  13: syntax_pos::source_map::SourceMap::bytepos_to_file_charpos
  14: syntax_pos::source_map::SourceMap::lookup_char_pos
  15: rustc_errors::emitter::EmitterWriter::get_multispan_max_line_num
  16: <rustc_errors::emitter::EmitterWriter as rustc_errors::emitter::Emitter>::emit_diagnostic
  17: <rustc_errors::json::JsonEmitter as rustc_errors::emitter::Emitter>::emit_diagnostic
  18: rustc_errors::HandlerInner::emit_diagnostic
  19: rustc_errors::diagnostic_builder::DiagnosticBuilder::emit
  20: rustc_parse::parser::expr::<impl rustc_parse::parser::Parser>::parse_if_expr
  21: rustc_parse::parser::expr::<impl rustc_parse::parser::Parser>::parse_bottom_expr
  22: rustc_parse::parser::expr::<impl rustc_parse::parser::Parser>::parse_prefix_expr
  23: rustc_parse::parser::expr::<impl rustc_parse::parser::Parser>::parse_assoc_expr_with
  24: rustc_parse::parser::stmt::<impl rustc_parse::parser::Parser>::parse_stmt_without_recovery
  25: rustc_parse::parser::stmt::<impl rustc_parse::parser::Parser>::parse_full_stmt
  26: syntax_expand::expand::parse_ast_fragment
  27: syntax_expand::mbe::macro_rules::ParserAnyMacro::make
  28: syntax_expand::expand::<impl syntax_expand::base::MacResult for syntax_expand::mbe::macro_rules::ParserAnyMacro>::make_stmts
  29: syntax_expand::expand::AstFragmentKind::make_from
  30: syntax_expand::expand::MacroExpander::fully_expand_fragment
  31: syntax_expand::expand::MacroExpander::expand_crate
  32: rustc_interface::passes::configure_and_expand_inner::{{closure}}
  33: rustc::util::common::time
  34: rustc_interface::passes::configure_and_expand_inner
  35: rustc_interface::passes::configure_and_expand::{{closure}}
  36: rustc_data_structures::box_region::PinnedGenerator<I,A,R>::new
  37: rustc_interface::passes::configure_and_expand
  38: rustc_interface::queries::Queries::expansion
  39: rustc_interface::interface::run_compiler_in_existing_thread_pool
  40: scoped_tls::ScopedKey<T>::set
  41: syntax::with_globals
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.

error: internal compiler error: unexpected panic

note: the compiler unexpectedly panicked. this is a bug.

note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports

note: rustc 1.42.0-nightly (da3629b05 2019-12-29) running on x86_64-unknown-linux-gnu

note: compiler flags: -C codegen-units=1 -C debuginfo=2 --crate-type bin

note: some of the compiler flags provided by cargo are hidden

query stack during panic:
end of query stack
error: could not compile `playground`.

To learn more, run the command again with --verbose.
@csmoe csmoe added A-parser Area: The parsing of Rust source code to an AST. C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ labels Jan 10, 2020
JohnTitor added a commit to rust-lang/glacier that referenced this issue Jan 10, 2020
@rust-lang-glacier-bot rust-lang-glacier-bot added the glacier ICE tracked in rust-lang/glacier. label Jan 10, 2020
Centril added a commit to Centril/rust that referenced this issue Jan 11, 2020
Do not ICE on unicode next point

Use `shrink_to_hi` instead of `next_point` and fix `next_point`.

Fix rust-lang#68000, fix rust-lang#68091, fix rust-lang#68092.
@bors bors closed this as completed in cacda2d Jan 11, 2020
@jieyouxu jieyouxu added A-diagnostics Area: Messages for errors, warnings, and lints D-unicode-unaware Diagnostics: Diagnostics that are unaware of unicode and trigger codepoint boundary assertions labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-parser Area: The parsing of Rust source code to an AST. C-bug Category: This is a bug. D-unicode-unaware Diagnostics: Diagnostics that are unaware of unicode and trigger codepoint boundary assertions glacier ICE tracked in rust-lang/glacier. I-ICE Issue: The compiler panicked, giving an Internal Compilation Error (ICE) ❄️ T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants