Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of issue = "0" in submodules (stdarch, cargo, and rustfmt) #67496

Closed
3 tasks done
rossmacarthur opened this issue Dec 21, 2019 · 2 comments · Fixed by #68880
Closed
3 tasks done

Remove use of issue = "0" in submodules (stdarch, cargo, and rustfmt) #67496

rossmacarthur opened this issue Dec 21, 2019 · 2 comments · Fixed by #68880
Labels
A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.

Comments

@rossmacarthur
Copy link
Contributor

rossmacarthur commented Dec 21, 2019 •
edited
Loading

With #41260 resolved, issue = "0" in unstable attributes is disallowed in the compiler because issue = "none" should be used instead. However, some submodules haven't been updated to use this yet.

Once this is done the code in src/libsyntax/attr.rs that allows issue = "0" can be updated.

See #67480 (comment)
@Centril Centril added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. labels Dec 21, 2019
This was referenced Dec 22, 2019
Merged
Merged
Merged
bors added a commit to rust-lang/cargo that referenced this issue Dec 22, 2019
@bors
Auto merge of #7738 - JohnTitor:issue-none, r=ehuss
2f52929 
Use issue = "none" instead of "0"

Replace `issue = "0"` with `"none"`

CC: rust-lang/rust#67496
@KamilaBorowska
Copy link
Contributor

KamilaBorowska commented Dec 27, 2019 •
edited
Loading

All those submodules merged the change.

@JohnTitor
Copy link
Member

JohnTitor commented Jan 13, 2020 •
edited
Loading

I think submodules don't actually block the work, we can move on. Nvm, updating stdarch is actually needed.

@JohnTitor JohnTitor mentioned this issue Feb 6, 2020
Merged
@bors bors closed this as completed in 1ad674a Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-stability Area: issues related to #[stable] and #[unstable] attributes themselves. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-cargo Relevant to the cargo team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-dev-tools Relevant to the dev-tools subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Forbid using 0 as issue number JohnTitor/rust
4 participants
@Centril @KamilaBorowska @rossmacarthur @JohnTitor