Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> #63514

Closed
2 tasks done
Tracked by #16
95th opened this issue Aug 13, 2019 · 6 comments
Closed
2 tasks done
Tracked by #16

Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> #63514

95th opened this issue Aug 13, 2019 · 6 comments
Labels
A-async-await Area: Async & Await A-result-option Area: Result and Option combinators AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. requires-nightly This issue requires a nightly compiler in some way. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@95th
Copy link
Contributor

95th commented Aug 13, 2019 •
edited
Loading

Currently map_ok and map_err methods are given for Poll<Result<T, E>>.

We should provide similar methods for Poll<Option<Result<T, E>>> as they are helpful in stream building code.

Steps

Open questions

None
@jonas-schievink jonas-schievink added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 13, 2019
@Centril Centril added B-unstable Blocker: Implemented in the nightly compiler and unstable. requires-nightly This issue requires a nightly compiler in some way. A-async-await Area: Async & Await labels Aug 13, 2019
@nikomatsakis nikomatsakis added the AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. label Aug 13, 2019
@95th 95th mentioned this issue Aug 15, 2019
Merged
@mzabaluev
Copy link
Contributor

Any plans to stabilize this?

@KodrAus KodrAus added I-nominated A-result-option Area: Result and Option combinators Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 29, 2020
@m-ou-se m-ou-se changed the title Provide map_ok and map_err method for Poll<Option<Result<T, E>>> Tracking issue for map_ok and map_err method for Poll<Option<Result<T, E>>> Dec 8, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Dec 8, 2020

There aren't any open questions about this feature, and this has seen quite a few releases already. So it looks like this would be ready for stabilization.

@rfcbot merge

@rfcbot
Copy link

rfcbot commented Dec 8, 2020 •
edited by dtolnay
Loading

Team member @m-ou-se has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Dec 8, 2020
@rfcbot rfcbot added the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Dec 9, 2020
@rfcbot
Copy link

rfcbot commented Dec 9, 2020

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot rfcbot removed the proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. label Dec 9, 2020
@rfcbot rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Dec 19, 2020
@rfcbot
Copy link

rfcbot commented Dec 19, 2020

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@spastorino spastorino removed the to-announce Announce this issue on triage meeting label Dec 31, 2020
@KodrAus KodrAus mentioned this issue Jan 13, 2021
Merged
JohnTitor added a commit to JohnTitor/rust that referenced this issue Jan 16, 2021
@JohnTitor
Rollup merge of rust-lang#80968 - KodrAus:stabilize/poll_map, r=Mark-…
605557f 
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
m-ou-se added a commit to m-ou-se/rust that referenced this issue Jan 16, 2021
@m-ou-se
Rollup merge of rust-lang#80968 - KodrAus:stabilize/poll_map, r=Mark-…
944ee6f 
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
m-ou-se added a commit to m-ou-se/rust that referenced this issue Jan 16, 2021
@m-ou-se
Rollup merge of rust-lang#80968 - KodrAus:stabilize/poll_map, r=Mark-…
dba6c9c 
…Simulacrum

Stabilize the poll_map feature

Stabilizes the `poll_map` feature as tracked by rust-lang#63514 (with a completed FCP).
@KodrAus
Copy link
Contributor

KodrAus commented Jan 22, 2021

This was stabilized in #80968

@KodrAus KodrAus closed this as completed Jan 22, 2021
@jplatte jplatte mentioned this issue Mar 2, 2021
Open
65 tasks
@johnsoncarlp johnsoncarlp mentioned this issue Jun 23, 2021
Closed
@teor2345 teor2345 mentioned this issue Aug 30, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-async-await Area: Async & Await A-result-option Area: Result and Option combinators AsyncAwait-Triaged Async-await issues that have been triaged during a working group meeting. B-unstable Blocker: Implemented in the nightly compiler and unstable. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. finished-final-comment-period The final comment period is finished for this PR / Issue. Libs-Small Libs issues that are considered "small" or self-contained Libs-Tracked Libs issues that are tracked on the team's project board. requires-nightly This issue requires a nightly compiler in some way. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@spastorino @nikomatsakis @m-ou-se @Centril @mzabaluev @jonas-schievink @KodrAus @rfcbot @95th