Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust could use linkonce_odr instead of internal on instantiations of generic functions #5490

Closed
thestinger opened this issue Mar 22, 2013 · 1 comment
Closed

rust could use linkonce_odr instead of internal on instantiations of generic functions #5490

thestinger opened this issue Mar 22, 2013 · 1 comment
Assignees
@pcwalton

Comments

@thestinger
Copy link
Contributor

This is how clang tells LLVM to merge C++ template instantiations. It's somewhat complicated for C++ as shown by their IR output tests but Rust might just need linkonce_odr without the exceptions.

It's possible this isn't actually useful because of the compilation model of crates though. @pcwalton: any idea if this would have any meaning in Rust's world?
@ghost ghost assigned pcwalton Mar 22, 2013
@thestinger
Copy link
Contributor Author

Closing for now, I don't think this applies to Rust's crate model.

oli-obk pushed a commit to oli-obk/rust that referenced this issue May 2, 2020
@bors
Auto merge of rust-lang#5490 - sinkuu:toplevel_ref_arg_for, r=phansch
9273eab 
Don't trigger toplevel_ref_arg for `for` loops

The lint suggests turning `for ref x in 0..10 {` into `for ref x in let x = &0..10; {`.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcwalton pcwalton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcwalton @thestinger